Yul: Immutable AST class with top-level block #15258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
clonker
force-pushed
the
immutable_ast_class
branch
from
9f43c25 to
7a46c24
Compare
5 tasks
Collaborator
|
Looks like this is in dire need of a rebase |
clonker
force-pushed
the
immutable_ast_class
branch
2 times, most recently
from
b1ae6a5 to
4247ad4
Compare
clonker
force-pushed
the
immutable_ast_class
branch
from
4247ad4 to
f261123
Compare
cameel
reviewed
Jul 25, 2024
Collaborator
cameel
left a comment
cameel
left a comment
There was a problem hiding this comment.
No issues on terms of correctness, but could use better naming and the override in compilability checker could be done differently. See comments.
clonker
force-pushed
the
immutable_ast_class
branch
from
9af3770 to
f2a572b
Compare
3 tasks
cameel
reviewed
Aug 1, 2024
Collaborator
There was a problem hiding this comment.
Unfortunately I did find some new stuff on this second pass:
- I think we should move
AsmAnalysisInfoto theASTstruct and make it immutable as well. It would reduce the risk of forgetting to update it and we would also be able to calculate it just once per AST. YulOptimizerTestallows arbitrary object nesting but does not handle that properly (only cares about the top-level one). And now with the extra copying added by this PR that gets extra unsafe, because we're not doing full copies of the objects. We should safeguard that with some asserts and maybe consider also actually fixing it properly (later, in a separate PR).
clonker
force-pushed
the
immutable_ast_class
branch
from
a057641 to
27e2479
Compare
clonker
force-pushed
the
immutable_ast_class
branch
2 times, most recently
from
ae6b298 to
ca2eabe
Compare
clonker
force-pushed
the
immutable_ast_class
branch
from
ca2eabe to
44bfa72
Compare
r0qs
reviewed
Aug 6, 2024
ekpyron
reviewed
Aug 6, 2024
ekpyron
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.