SP1 : security ports #38
Assignees
Comments
This was referenced Jun 14, 2024
Merged
Merged
wwared
added a commit
that referenced
this issue
Jun 19, 2024
The MemoryProgram chip was modified to only be included in the first shard. However, the rust out-of-circuit verifier was not updated to account for this since it still expects the chip to be present in every shard, and the in-circuit recursive verifier was updated with constraints that are only valid if the core proof has a single shard. This commit temporarily comments out these additional checks, but this should be reverted when the verifier and Memory chip-related fixes are integrated. This is related to the batch of PRs for issue #38 It might be necessary to revert commit 6aea5dc after the proper fixes are incorporated.
wwared
added a commit
that referenced
this issue
Jun 19, 2024
The MemoryProgram chip was modified to only be included in the first shard. However, the rust out-of-circuit verifier was not updated to account for this since it still expects the chip to be present in every shard, and the in-circuit recursive verifier was updated with constraints that are only valid if the core proof has a single shard. This commit temporarily comments out these additional checks, but this should be reverted when the verifier and Memory chip-related fixes are integrated. This is related to the batch of PRs for issue #38 It might be necessary to revert commit 6aea5dc after the proper fixes are incorporated.
Merged
wwared
added a commit
that referenced
this issue
Jun 19, 2024
The MemoryProgram chip was modified to only be included in the first shard. However, the rust out-of-circuit verifier was not updated to account for this since it still expects the chip to be present in every shard, and the in-circuit recursive verifier was updated with constraints that are only valid if the core proof has a single shard. This commit temporarily comments out these additional checks, but this should be reverted when the verifier and Memory chip-related fixes are integrated. This is related to the batch of PRs for issue #38 It might be necessary to revert commit 6aea5dc after the proper fixes are incorporated.
wwared
added a commit
that referenced
this issue
Jun 19, 2024
The MemoryProgram chip was modified to only be included in the first shard. However, the rust out-of-circuit verifier was not updated to account for this since it still expects the chip to be present in every shard, and the in-circuit recursive verifier was updated with constraints that are only valid if the core proof has a single shard. This commit temporarily comments out these additional checks, but this should be reverted when the verifier and Memory chip-related fixes are integrated. This is related to the batch of PRs for issue #38 It might be necessary to revert commit 6aea5dc after the proper fixes are incorporated.
wwared
added a commit
that referenced
this issue
Jun 20, 2024
Related to #38 and the performance regression due to the nonce columns
wwared
added a commit
that referenced
this issue
Jun 20, 2024
The MemoryProgram chip was modified to only be included in the first shard. However, the rust out-of-circuit verifier was not updated to account for this since it still expects the chip to be present in every shard, and the in-circuit recursive verifier was updated with constraints that are only valid if the core proof has a single shard. This commit temporarily comments out these additional checks, but this should be reverted when the verifier and Memory chip-related fixes are integrated. This is related to the batch of PRs for issue #38 It might be necessary to revert commit 6aea5dc after the proper fixes are incorporated.
huitseeker
pushed a commit
that referenced
this issue
Jun 24, 2024
The MemoryProgram chip was modified to only be included in the first shard. However, the rust out-of-circuit verifier was not updated to account for this since it still expects the chip to be present in every shard, and the in-circuit recursive verifier was updated with constraints that are only valid if the core proof has a single shard. This commit temporarily comments out these additional checks, but this should be reverted when the verifier and Memory chip-related fixes are integrated. This is related to the batch of PRs for issue #38 It might be necessary to revert commit 6aea5dc after the proper fixes are incorporated.
wwared
added a commit
that referenced
this issue
Jun 24, 2024
The MemoryProgram chip was modified to only be included in the first shard. However, the rust out-of-circuit verifier was not updated to account for this since it still expects the chip to be present in every shard, and the in-circuit recursive verifier was updated with constraints that are only valid if the core proof has a single shard. This commit temporarily comments out these additional checks, but this should be reverted when the verifier and Memory chip-related fixes are integrated. This is related to the batch of PRs for issue #38 It might be necessary to revert commit 6aea5dc after the proper fixes are incorporated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should port the security issues in SP1 not yet ported in Sphinx.
To recall, the last forward port PR is: https://github.com/wormhole-foundation/wp1/pull/230
Those include at least the following:
https://github.com/succinctlabs/sp1/pulls?q=is%3Apr+is%3Aclosed+base%3Amain+merged%3A%3E2024-05-21+
The text was updated successfully, but these errors were encountered: