Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SHARD_BATCH_SIZE=0 support #44

Closed
wwared opened this issue Jun 15, 2024 · 1 comment · Fixed by #40
Closed

fix SHARD_BATCH_SIZE=0 support #44

wwared opened this issue Jun 15, 2024 · 1 comment · Fixed by #40

Comments

@wwared
Copy link
Contributor

wwared commented Jun 15, 2024

SHARD_BATCH_SIZE=0 does not work the same way as it used to anymore after #40, and if you set it will panic with "chunk size must be non-zero" here

As far as I can tell this is also an issue in current upstream dev, but it might be possible to change that particular code to handle SHARD_BATCH_SIZE=0 and revert to previous behavior (I think), hopefully in a minimally intrusive way

This is because this check still exists, but no longer works due to the new code here

Originally posted by @wwared in #40 (comment)

@wwared
Copy link
Contributor Author

wwared commented Jun 18, 2024

Fixed by #40

@wwared wwared closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant