-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Forward ports #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update comments prover type lint change to network fix clean feat: enforce only `dev` can merge into `main` (#844) fix: gnark-ffi linking on mac fix: rename remote to network fix book feat: runtime instruction/syscall report (#839) Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu> chore: add network requester to requested proof (#845) feat: execute() exposes ExecutionReport (#847) fix: remove aggregation programs (#849) chore: default reconstruct commitments = true fix: plonk feature off by default (#852) feat: generic const expr (#854) Co-authored-by: Chris Tian <chris@succinct.xyz> doc: recursive program docs (#855) feat: feature flag `alloy_sol_types` (#850) chore: bump plonk artifacts (#864) chore: program doc and remove unnecessary clones (#857) contracts clean fix clean try permalink fix feat: check version for proof requests (#862) feat(sdk): add explorer link (#858)
huitseeker
force-pushed
the
forward_ports_37
branch
from
June 15, 2024 16:21
9964f2b
to
431761d
Compare
We use a different set of precompiles and different compilation options
huitseeker
force-pushed
the
forward_ports_37
branch
from
June 16, 2024 18:55
e597eef
to
d2c6c90
Compare
huitseeker
force-pushed
the
forward_ports_37
branch
from
June 16, 2024 19:00
d2c6c90
to
43636c6
Compare
wwared
approved these changes
Jun 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor non-blocking nit I found below
storojs72
approved these changes
Jun 16, 2024
adr1anh
approved these changes
Jun 17, 2024
…ules - Renamed the utility function `pad_vec_rows` to `pad_rows` across the entire precompiles library. - Updated all modules in the precompiles library to use the new function name `pad_rows`. - Changes were purely semantic with no alterations to underlying logic or functionality of the code. - Simplified the `pad_vec_rows` function in core/src/utils/mod.rs to incorporate the functionality of `pad_rows` to pad both vectors and nested vectors to a power of two with a minimum size of 8.
wwared
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes to #38
This ports the following upstream PRs:
Note
this brings us to par with testnet-v1.0.5 : https://github.com/succinctlabs/sp1/tree/v1.0.5-testnet