Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Forward ports #45

Merged
merged 7 commits into from
Jun 17, 2024
Merged

feat: Forward ports #45

merged 7 commits into from
Jun 17, 2024

Conversation

huitseeker
Copy link
Contributor

@huitseeker huitseeker commented Jun 15, 2024

This contributes to #38

This ports the following upstream PRs:

Note

this brings us to par with testnet-v1.0.5 : https://github.com/succinctlabs/sp1/tree/v1.0.5-testnet

update comments

prover type

lint

change to network

fix

clean

feat: enforce only `dev` can merge into `main` (#844)

fix: gnark-ffi linking on mac

fix: rename remote to network

fix

book

feat: runtime instruction/syscall report (#839)

Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu>

chore: add network requester to requested proof (#845)

feat: execute() exposes ExecutionReport (#847)

fix: remove aggregation programs (#849)

chore: default reconstruct commitments = true

fix: plonk feature off by default (#852)

feat: generic const expr (#854)

Co-authored-by: Chris Tian <chris@succinct.xyz>

doc: recursive program docs (#855)

feat: feature flag `alloy_sol_types` (#850)

chore: bump plonk artifacts (#864)

chore: program doc and remove unnecessary clones  (#857)

contracts

clean

fix

clean

try permalink

fix

feat: check version for proof requests (#862)

feat(sdk): add explorer link (#858)
@huitseeker huitseeker requested a review from wwared June 15, 2024 16:08
@huitseeker huitseeker changed the title Forward ports 37 feat: Forward ports Jun 15, 2024
@huitseeker huitseeker marked this pull request as ready for review June 16, 2024 19:08
Copy link
Contributor

@wwared wwared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor non-blocking nit I found below

core/src/utils/mod.rs Outdated Show resolved Hide resolved
…ules

- Renamed the utility function `pad_vec_rows` to `pad_rows` across the entire precompiles library.
- Updated all modules in the precompiles library to use the new function name `pad_rows`.
- Changes were purely semantic with no alterations to underlying logic or functionality of the code.
- Simplified the `pad_vec_rows` function in core/src/utils/mod.rs to incorporate the functionality of `pad_rows` to pad both vectors and nested vectors to a power of two with a minimum size of 8.
@huitseeker huitseeker merged commit f1cbdc2 into plonk Jun 17, 2024
5 of 6 checks passed
@huitseeker huitseeker deleted the forward_ports_37 branch June 17, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants