Add --space-before-function-paren option #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corresponds to ESLint's `space-before-function-paren` "always" option: http://eslint.org/docs/rules/space-before-function-paren#always See prettier#1139
|
Thank you! I just updated the master branch, but there have been some changes. Can you solve the conflicts please? |
|
Sure thing, I also added documentation. |
This was referenced Jun 20, 2017
|
@josephfrazier Can you submit this as a merge request to the |
|
At https://github.com/prettier/prettier/, this has been split into prettier#3845 and prettier#3847 (this one has a PR at prettier#3903) |
brodycj
pushed a commit
to bangkokjs/prettierx-0.4.x-fork
that referenced
this pull request
Dec 30, 2018
ported from prettier-miscellaneous (arijs#22) with test coverage added for space-before-function-paren not enabled TODO: Known issue with generics in TypeScript Co-authored-by: Christopher J. Brody <chris.brody@gmail.com> Co-authored-by: Joseph Frazier <1212jtraceur@gmail.com> Co-authored-by: Ika <ikatyang@gmail.com> Co-authored-by: Lucas Azzola <derflatulator@gmail.com>
brodycj
pushed a commit
to bangkokjs/prettierx-0.4.x-fork
that referenced
this pull request
Jan 1, 2019
ported (reimplemented) from prettier-miscellaneous (arijs#22) with test coverage added for space-before-function-paren not enabled configuration & documentation according to new prettier format TODO: Known issue with generics in TypeScript Co-authored-by: Christopher J. Brody <chris.brody@gmail.com> Co-authored-by: Joseph Frazier <1212jtraceur@gmail.com> Co-authored-by: Rafael Hengles <rafael@hengles.net> Co-authored-by: Ika <ikatyang@gmail.com> Co-authored-by: Lucas Azzola <derflatulator@gmail.com>
brodycj
pushed a commit
to bangkokjs/prettierx-0.4.x-fork
that referenced
this pull request
Jan 2, 2019
ported (largely reimplemented) from prettier-miscellaneous (arijs#22) with ES test moved to eslint-compat subdirectory; test space-before-function-paren with real member function; test coverage added for space-before-function-paren not enabled; configuration & documentation according to new prettier format; tslint-compat test to cover use of TypeScript generics; issue with TypeScript generics resolved; and space-before-function-paren option added to README.md. Co-authored-by: Christopher J. Brody <chris.brody@gmail.com> Co-authored-by: Joseph Frazier <1212jtraceur@gmail.com> Co-authored-by: Rafael Hengles <rafael@hengles.net> Co-authored-by: Ika <ikatyang@gmail.com> Co-authored-by: Lucas Azzola <derflatulator@gmail.com>
brodycj
pushed a commit
to bangkokjs/prettierx-0.4.x-fork
that referenced
this pull request
Jan 2, 2019
ported (largely reimplemented) from prettier-miscellaneous (arijs#22) with ES test moved to eslint-compat subdirectory; test space-before-function-paren with real member function; test coverage added for space-before-function-paren not enabled; configuration & documentation according to new prettier format; tslint-compat test to cover use of TypeScript generics; issue with TypeScript generics resolved; and space-before-function-paren option added to README.md. Co-authored-by: Christopher J. Brody <chris.brody@gmail.com> Co-authored-by: Joseph Frazier <1212jtraceur@gmail.com> Co-authored-by: Rafael Hengles <rafael@hengles.net> Co-authored-by: Ika <ikatyang@gmail.com> Co-authored-by: Lucas Azzola <derflatulator@gmail.com>
|
why this function |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to ESLint's
space-before-function-paren"always"option: http://eslint.org/docs/rules/space-before-function-paren#always
See prettier#1139
Note that this is based on upstream prettier's master branch, so that should be merged before this. Only the last two commits in this PR are the meaningful ones.