Fix(cv_device_v3): device decommissioning fails if a device is not streaming and not provisioned #700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Sometimes devices can go offline and be deleted from Network Provisioning,currently we only check provisioned devices when getting their facts instead of checking devices are in the inventory (that contains both provisioned and unprovisioned devices)
With this change instead of getting each device data with single gets (that's only fetching provisioned devices), I get the full inventory (both provisioned and unprovisioned devices) and then figure out the serialNumber from there and decommission that
Related Issue(s)
Fixes #657
Component(s) name
arista.cvp.cv_device_v3
Proposed changes
How to test
Pick a device that is not streaming (shutdown TerminAttr to test if you don't have one), go to Network Provisioning, right click on the device and select remove, click save and then run the below playbook
Checklist
User Checklist
Repository Checklist