Refactor(eos_designs)!: Rename wan_mode 'autovpn' to 'legacy-autovpn' (…

…#4473)
aristanetworks · Sep 16, 2024 · 7f41eee · 7f41eee
1 parent fb085fb
commit 7f41eee
Show file tree

Hide file tree

Showing 31 changed files with 137 additions and 129 deletions.
diff --git a/ansible_collections/arista/avd/docs/porting-guides/5.x.x.md b/ansible_collections/arista/avd/docs/porting-guides/5.x.x.md
@@ -315,6 +315,15 @@ The description can be reverted manually if needed:
 +mgmt_interface_description: "oob_management"
 ```
 
+### `wan_mode: autovpn` renamed `wan_mode: legacy-autovpn`
+
+With AVD version 5.0.0 the valid values for `wan_mode` key have changed. If using the `autovpn` mode in AVD 4.x, the `wan_mode` key needs to be updated to `legacy-autovpn`.
+
+```diff
+-  wan_mode: autovpn
++  wan_mode: legacy-autovpn
+```
+
 ### custom_structured_configuration_prefix no longer accepts a string
 
 Starting AVD 5.0.0, `custom_structured_configuration_prefix` only accepts a list of strings.

diff --git a/ansible_collections/arista/avd/docs/release-notes/5.x.x.md b/ansible_collections/arista/avd/docs/release-notes/5.x.x.md
@@ -190,6 +190,12 @@ The updated version gives more flexibility to customizing interface descriptions
 
 See the [Porting guide for AVD 5.x.x](../porting-guides/5.x.x.md#avdinterfacedescriptions-breaking-changes)
 
+#### `wan_mode: autovpn` renamed `wan_mode: legacy-autovpn`
+
+With AVD version 5.0.0 the valid values for `wan_mode` key are now `legacy-autovpn | cv-pathfinder`.
+
+See the [porting guide](../porting-guides/5.x.x.md#wan-mode-autovpn-renamed-wan-mode-legacy-vpn) for details.
+
 ### Other breaking or behavioral changes
 
 Breaking changes may require modifications to the inventory or playbook. See the [Porting guide for AVD 5.x.x](../porting-guides/5.x.x.md)

diff --git a/...gns_negative_unit_tests/inventory/host_vars/invalid-wan-role-overlay-routing-protocol.yml b/...gns_negative_unit_tests/inventory/host_vars/invalid-wan-role-overlay-routing-protocol.yml
@@ -1,5 +1,5 @@
 ---
-wan_mode: autovpn
+wan_mode: legacy-autovpn
 type: wan_router
 fabric_name: FABRIC_WAN_ROLE_OVERLAY_ROUTING_PROTOCOL
 

diff --git a/..._designs_negative_unit_tests/inventory/host_vars/ipv4-acl-in-missing-on-wan-interface.yml b/..._designs_negative_unit_tests/inventory/host_vars/ipv4-acl-in-missing-on-wan-interface.yml
@@ -1,6 +1,6 @@
 ---
 type: wan_router
-wan_mode: autovpn
+wan_mode: legacy-autovpn
 wan_router:
   nodes:
     - bgp_as: 65000

diff --git a/...onfigs/autovpn-edge-no-default-policy.cfg → ...legacy-autovpn-edge-no-default-policy.cfg b/...onfigs/autovpn-edge-no-default-policy.cfg → ...legacy-autovpn-edge-no-default-policy.cfg
@@ -23,7 +23,7 @@ flow tracking hardware
 !
 service routing protocols model multi-agent
 !
-hostname autovpn-edge-no-default-policy
+hostname legacy-autovpn-edge-no-default-policy
 !
 router path-selection
    tcp mss ceiling ipv4 ingress
@@ -32,12 +32,12 @@ router path-selection
       ipsec profile AUTOVPN
       !
       local interface Ethernet1
-         stun server-profile INET-autovpn-rr3-Ethernet1
+         stun server-profile INET-legacy-autovpn-rr3-Ethernet1
       !
       peer dynamic
       !
       peer static router-ip 2.2.2.2
-         name autovpn-rr3
+         name legacy-autovpn-rr3
          ipv4 address 10.7.7.7
    !
    load-balance policy LB-DEFAULT-POLICY-CONTROL-PLANE
@@ -116,7 +116,7 @@ interface Loopback0
    ip address 192.168.30.1/32
 !
 interface Vxlan1
-   description autovpn-edge-no-default-policy_VTEP
+   description legacy-autovpn-edge-no-default-policy_VTEP
    vxlan source-interface Dps1
    vxlan udp-port 4789
    vxlan vrf default vni 1
@@ -177,7 +177,7 @@ router bgp 65000
    neighbor WAN-OVERLAY-PEERS send-community
    neighbor WAN-OVERLAY-PEERS maximum-routes 0
    neighbor 2.2.2.2 peer group WAN-OVERLAY-PEERS
-   neighbor 2.2.2.2 description autovpn-rr3
+   neighbor 2.2.2.2 description legacy-autovpn-rr3
    redistribute connected route-map RM-CONN-2-BGP
    !
    address-family evpn
@@ -215,7 +215,7 @@ router bgp 65000
 !
 stun
    client
-      server-profile INET-autovpn-rr3-Ethernet1
+      server-profile INET-legacy-autovpn-rr3-Ethernet1
          ip address 10.7.7.7
          ssl profile STUN-DTLS
 !

diff --git a/...t_tests/intended/configs/autovpn-edge.cfg → .../intended/configs/legacy-autovpn-edge.cfg b/...t_tests/intended/configs/autovpn-edge.cfg → .../intended/configs/legacy-autovpn-edge.cfg
@@ -23,7 +23,7 @@ flow tracking hardware
 !
 service routing protocols model multi-agent
 !
-hostname autovpn-edge
+hostname legacy-autovpn-edge
 !
 router path-selection
    tcp mss ceiling ipv4 ingress
@@ -32,16 +32,16 @@ router path-selection
       ipsec profile AUTOVPN
       !
       local interface Ethernet1
-         stun server-profile INET-autovpn-rr1-Ethernet1 INET-autovpn-rr2-Ethernet1
+         stun server-profile INET-legacy-autovpn-rr1-Ethernet1 INET-legacy-autovpn-rr2-Ethernet1
       !
       peer dynamic
       !
       peer static router-ip 192.168.131.1
-         name autovpn-rr1
+         name legacy-autovpn-rr1
          ipv4 address 10.7.7.7
       !
       peer static router-ip 192.168.131.2
-         name autovpn-rr2
+         name legacy-autovpn-rr2
          ipv4 address 10.8.8.8
    !
    path-group MPLS id 100
@@ -139,7 +139,7 @@ interface Loopback0
    ip address 192.168.30.1/32
 !
 interface Vxlan1
-   description autovpn-edge_VTEP
+   description legacy-autovpn-edge_VTEP
    vxlan source-interface Dps1
    vxlan udp-port 4789
    vxlan vrf default vni 1
@@ -205,9 +205,9 @@ router bgp 65000
    neighbor WAN-OVERLAY-PEERS send-community
    neighbor WAN-OVERLAY-PEERS maximum-routes 0
    neighbor 192.168.131.1 peer group WAN-OVERLAY-PEERS
-   neighbor 192.168.131.1 description autovpn-rr1
+   neighbor 192.168.131.1 description legacy-autovpn-rr1
    neighbor 192.168.131.2 peer group WAN-OVERLAY-PEERS
-   neighbor 192.168.131.2 description autovpn-rr2
+   neighbor 192.168.131.2 description legacy-autovpn-rr2
    redistribute connected route-map RM-CONN-2-BGP
    !
    address-family evpn
@@ -238,9 +238,9 @@ router bgp 65000
 !
 stun
    client
-      server-profile INET-autovpn-rr1-Ethernet1
+      server-profile INET-legacy-autovpn-rr1-Ethernet1
          ip address 10.7.7.7
-      server-profile INET-autovpn-rr2-Ethernet1
+      server-profile INET-legacy-autovpn-rr2-Ethernet1
          ip address 10.8.8.8
 !
 end
diff --git a/...it_tests/intended/configs/autovpn-rr1.cfg → ...s/intended/configs/legacy-autovpn-rr1.cfg b/...it_tests/intended/configs/autovpn-rr1.cfg → ...s/intended/configs/legacy-autovpn-rr1.cfg
@@ -23,7 +23,7 @@ flow tracking hardware
 !
 service routing protocols model multi-agent
 !
-hostname autovpn-rr1
+hostname legacy-autovpn-rr1
 !
 router path-selection
    peer dynamic source stun
@@ -35,7 +35,7 @@ router path-selection
       local interface Ethernet1
       !
       peer static router-ip 192.168.131.2
-         name autovpn-rr2
+         name legacy-autovpn-rr2
          ipv4 address 10.8.8.8
    !
    path-group LTE id 102
@@ -119,7 +119,7 @@ interface Loopback0
    ip address 192.168.31.1/32
 !
 interface Vxlan1
-   description autovpn-rr1_VTEP
+   description legacy-autovpn-rr1_VTEP
    vxlan source-interface Dps1
    vxlan udp-port 4789
    vxlan vrf default vni 1
@@ -187,7 +187,7 @@ router bgp 65000
    neighbor WAN-RR-OVERLAY-PEERS send-community
    neighbor WAN-RR-OVERLAY-PEERS maximum-routes 0
    neighbor 192.168.131.2 peer group WAN-RR-OVERLAY-PEERS
-   neighbor 192.168.131.2 description autovpn-rr2
+   neighbor 192.168.131.2 description legacy-autovpn-rr2
    redistribute connected route-map RM-CONN-2-BGP
    !
    address-family evpn

diff --git a/...it_tests/intended/configs/autovpn-rr2.cfg → ...s/intended/configs/legacy-autovpn-rr2.cfg b/...it_tests/intended/configs/autovpn-rr2.cfg → ...s/intended/configs/legacy-autovpn-rr2.cfg
@@ -23,7 +23,7 @@ flow tracking hardware
 !
 service routing protocols model multi-agent
 !
-hostname autovpn-rr2
+hostname legacy-autovpn-rr2
 !
 router path-selection
    peer dynamic source stun
@@ -35,7 +35,7 @@ router path-selection
       local interface Ethernet1
       !
       peer static router-ip 192.168.131.1
-         name autovpn-rr1
+         name legacy-autovpn-rr1
          ipv4 address 10.7.7.7
    !
    path-group LTE id 102
@@ -118,7 +118,7 @@ interface Loopback0
    ip address 192.168.31.2/32
 !
 interface Vxlan1
-   description autovpn-rr2_VTEP
+   description legacy-autovpn-rr2_VTEP
    vxlan source-interface Dps1
    vxlan udp-port 4789
    vxlan vrf default vni 1
@@ -188,7 +188,7 @@ router bgp 65000
    neighbor WAN-RR-OVERLAY-PEERS send-community
    neighbor WAN-RR-OVERLAY-PEERS maximum-routes 0
    neighbor 192.168.131.1 peer group WAN-RR-OVERLAY-PEERS
-   neighbor 192.168.131.1 description autovpn-rr1
+   neighbor 192.168.131.1 description legacy-autovpn-rr1
    redistribute connected route-map RM-CONN-2-BGP
    !
    address-family evpn

diff --git a/...onfigs/autovpn-edge-no-default-policy.yml → ...legacy-autovpn-edge-no-default-policy.yml b/...onfigs/autovpn-edge-no-default-policy.yml → ...legacy-autovpn-edge-no-default-policy.yml
@@ -1,4 +1,4 @@
-hostname: autovpn-edge-no-default-policy
+hostname: legacy-autovpn-edge-no-default-policy
 is_deployed: true
 router_bgp:
   as: '65000'
@@ -49,8 +49,8 @@ router_bgp:
   neighbors:
   - ip_address: 2.2.2.2
     peer_group: WAN-OVERLAY-PEERS
-    peer: autovpn-rr3
-    description: autovpn-rr3
+    peer: legacy-autovpn-rr3
+    description: legacy-autovpn-rr3
   vrfs:
   - name: default
     rd: 192.168.30.1:1
@@ -216,12 +216,12 @@ router_path_selection:
     - name: Ethernet1
       stun:
         server_profiles:
-        - INET-autovpn-rr3-Ethernet1
+        - INET-legacy-autovpn-rr3-Ethernet1
     dynamic_peers:
       enabled: true
     static_peers:
     - router_ip: 2.2.2.2
-      name: autovpn-rr3
+      name: legacy-autovpn-rr3
       ipv4_addresses:
       - 10.7.7.7
     ipsec_profile: AUTOVPN
@@ -253,7 +253,7 @@ router_path_selection:
 stun:
   client:
     server_profiles:
-    - name: INET-autovpn-rr3-Ethernet1
+    - name: INET-legacy-autovpn-rr3-Ethernet1
       ip_address: 10.7.7.7
       ssl_profile: STUN-DTLS
 application_traffic_recognition:
@@ -279,7 +279,7 @@ dps_interfaces:
     hardware: FLOW-TRACKER
 vxlan_interface:
   vxlan1:
-    description: autovpn-edge-no-default-policy_VTEP
+    description: legacy-autovpn-edge-no-default-policy_VTEP
     vxlan:
       udp_port: 4789
       source_interface: Dps1

diff --git a/...ended/structured_configs/autovpn-edge.yml → ...tructured_configs/legacy-autovpn-edge.yml b/...ended/structured_configs/autovpn-edge.yml → ...tructured_configs/legacy-autovpn-edge.yml
@@ -1,4 +1,4 @@
-hostname: autovpn-edge
+hostname: legacy-autovpn-edge
 is_deployed: true
 router_bgp:
   as: '65000'
@@ -49,12 +49,12 @@ router_bgp:
   neighbors:
   - ip_address: 192.168.131.1
     peer_group: WAN-OVERLAY-PEERS
-    peer: autovpn-rr1
-    description: autovpn-rr1
+    peer: legacy-autovpn-rr1
+    description: legacy-autovpn-rr1
   - ip_address: 192.168.131.2
     peer_group: WAN-OVERLAY-PEERS
-    peer: autovpn-rr2
-    description: autovpn-rr2
+    peer: legacy-autovpn-rr2
+    description: legacy-autovpn-rr2
   vrfs:
   - name: default
     rd: 192.168.30.1:1
@@ -202,17 +202,17 @@ router_path_selection:
     - name: Ethernet1
       stun:
         server_profiles:
-        - INET-autovpn-rr1-Ethernet1
-        - INET-autovpn-rr2-Ethernet1
+        - INET-legacy-autovpn-rr1-Ethernet1
+        - INET-legacy-autovpn-rr2-Ethernet1
     dynamic_peers:
       enabled: true
     static_peers:
     - router_ip: 192.168.131.1
-      name: autovpn-rr1
+      name: legacy-autovpn-rr1
       ipv4_addresses:
       - 10.7.7.7
     - router_ip: 192.168.131.2
-      name: autovpn-rr2
+      name: legacy-autovpn-rr2
       ipv4_addresses:
       - 10.8.8.8
     ipsec_profile: AUTOVPN
@@ -270,9 +270,9 @@ router_path_selection:
 stun:
   client:
     server_profiles:
-    - name: INET-autovpn-rr1-Ethernet1
+    - name: INET-legacy-autovpn-rr1-Ethernet1
       ip_address: 10.7.7.7
-    - name: INET-autovpn-rr2-Ethernet1
+    - name: INET-legacy-autovpn-rr2-Ethernet1
       ip_address: 10.8.8.8
 application_traffic_recognition:
   application_profiles:
@@ -301,7 +301,7 @@ dps_interfaces:
     hardware: FLOW-TRACKER
 vxlan_interface:
   vxlan1:
-    description: autovpn-edge_VTEP
+    description: legacy-autovpn-edge_VTEP
     vxlan:
       udp_port: 4789
       source_interface: Dps1

diff --git a/...tended/structured_configs/autovpn-rr1.yml → ...structured_configs/legacy-autovpn-rr1.yml b/...tended/structured_configs/autovpn-rr1.yml → ...structured_configs/legacy-autovpn-rr1.yml
@@ -1,4 +1,4 @@
-hostname: autovpn-rr1
+hostname: legacy-autovpn-rr1
 is_deployed: true
 router_bgp:
   as: '65000'
@@ -74,8 +74,8 @@ router_bgp:
   neighbors:
   - ip_address: 192.168.131.2
     peer_group: WAN-RR-OVERLAY-PEERS
-    peer: autovpn-rr2
-    description: autovpn-rr2
+    peer: legacy-autovpn-rr2
+    description: legacy-autovpn-rr2
   vrfs:
   - name: default
     rd: 192.168.31.1:1
@@ -186,7 +186,7 @@ router_path_selection:
     - name: Ethernet1
     static_peers:
     - router_ip: 192.168.131.2
-      name: autovpn-rr2
+      name: legacy-autovpn-rr2
       ipv4_addresses:
       - 10.8.8.8
     ipsec_profile: AUTOVPN
@@ -267,7 +267,7 @@ dps_interfaces:
     hardware: FLOW-TRACKER
 vxlan_interface:
   vxlan1:
-    description: autovpn-rr1_VTEP
+    description: legacy-autovpn-rr1_VTEP
     vxlan:
       udp_port: 4789
       source_interface: Dps1