Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active_callback no longer works with option_type = option? #1745

Closed
akosipau opened this issue Jan 7, 2018 · 5 comments
Closed

active_callback no longer works with option_type = option? #1745

akosipau opened this issue Jan 7, 2018 · 5 comments
Milestone

Comments

@akosipau
Copy link

akosipau commented Jan 7, 2018

Issue description: It seems that active_callback or required argument no longer work when option_type config is option.

Version used:

(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)

Using theme_mods or options? options

Code to reproduce the issue (config + field(s))

@coleh33
Copy link

coleh33 commented Jan 12, 2018

I also am seeing the same issue after updating to the latest develop branch. The required argument no longer is working.

@stylethemes
Copy link

same problem here after updating to the latest wp.org version

@pagelab
Copy link
Contributor

pagelab commented Jan 15, 2018

Also happening when option_type is checkbox

@aristath
Copy link
Contributor

I just pushed a commit that should fix this, can you please check the develop branch? Thanks!

@stylethemes
Copy link

I actually did solve it without the develop branch I just did replace the value in the active_callback from on to 1 and it did work

note: I'm working with the last wp.org version

@aristath aristath added this to the 3.0.23 milestone Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants