Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Value in the Dimension control #1844

Closed
sergeysedykh opened this issue Mar 26, 2018 · 2 comments
Closed

Invalid Value in the Dimension control #1844

sergeysedykh opened this issue Mar 26, 2018 · 2 comments
Labels
bug

Comments

@sergeysedykh
Copy link

Issue description:

Even if we provide the correct value, like 100px there's an alert: Invalid Value.

The dimension is however applied correctly on the front-end.

Version used:

Develop branch.

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

Just the basic dimension control with default parameters.
@aristath aristath added the bug label Mar 26, 2018
@aristath
Copy link
Contributor

I saw that too these past few days, just didn't have time to debug it.
I'll check into this today if I find some free time 👍

@aristath
Copy link
Contributor

Fixed

aristath added a commit that referenced this issue Mar 26, 2018
@aristath
Merge branch 'develop' into postMessage-refactor
ff87a42 
* develop:
  Validation !== Sanitization
  'fr' is a new valid css unit
  fixes #1844
  Add a preset argument to controls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aristath @sergeysedykh