-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP creates notice when typography settings are used without "font-family" parameter. #1935
Comments
It seems that this is a duplicate of #1916. |
I have reopened this issue because |
Marking this one as a bug and adding to the 3.0.34 milestone 👍 |
Just jumping to say that this is exactly how I want to use Kirki for typography. Defaults for body/headings, and only size/variant/line-height (not font-family) control for each individual h1/h2/h3. Looking forward to this update. The typography field is EXTREMELY powerful as-is, and this just makes it more flexible :) Thanks! |
@andreikorzhyts
Unitless dimension controls are now implemented in the develop branch (see commit b01ba40) and will be included in the next release. See example control in https://github.com/aristath/kirki/blob/89e34e9dfb46f338c74c512c2baf97e37cfcb1be/example.php#L375-L377
I don't understand... what does text-transform have to do with dimension controls? You can add a radio control, radio-buttonset or any other control like that, but dimension doesn't make a lot of sense to me. Closing as a duplicate of #1797, it is now possible to use typography controls without a font-family (develop branch) |
Issue description:
We set font-family for many elements globally, and then set other typography parameters for every element individually. We don't want set duplicate
font-family
parameters for every elements. How to realize this method correctly?PHP notice:
Notice: Undefined index: font-family in E:...\kirki\modules\webfonts\class-kirki-fonts-google.php on line 133
Version used:
3.0.33
Using theme_mods or options?
theme_mod
Code to reproduce the issue (config + field(s))
The text was updated successfully, but these errors were encountered: