fix: Enable state_value_template in Home Assistant discovery #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
arjenhiemstra
added a commit
that referenced
this pull request
Feb 11, 2024
Changes since 2.7.0 feat: add check on username/password fields and extend length to 32 chars (#177 from sanderkob, thanks!) feat: Add support for AutoTemp version 12 and 13 feat: make wifi AP password configurable feat: update to ArduinoJSON 7.0.3 fix: tweaks for AP mode timeout fix: reconnect wifi after wifi settings save only if SSID and/or password have changed fix: Update HA auto discovery to display on/off status correctly (#229 from bjw-s, thanks!) Firmware binary (CVE HW rev.2 and NON-CVE): https://github.com/arjenhiemstra/ithowifi/raw/master/compiled_firmware_files/unified_hw2_noncve/nrgitho-v2.7.1.bin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting a
state_value_template, the "Unknown" state issue in Home Assistant (as also recently discussed in https://gathering.tweakers.net/forum/list_messages/1976492) disappears as Home Assistant will always have a way to determine the current on/off state.