Updated setting labels for Itho devices #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperslits
changed the title
|
@arjenhiemstra : gentle nudge. |
|
Thanks for the PR and sorry for the wait! At one hand I like the additions, on the other hand, these labels are/were created by a script which might result in a overwrite on a next update of itho device/firmware versions. |
|
See also repo of @tomkooij It would be great to pick these script as basis and put all hand made changes in those scripts for future use |
|
@jasperslits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some labels for settings had typos and or partial Dutch translations. Initial around of cleanups on formatting with some quick wins.
Covers: WPU, HRU350, HRU 200, HRU ECO, autotemp.
Added field number for settings and status messages for consistency with WPU.