-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the ARM for check_std #4
base: main
Are you sure you want to change the base?
Conversation
- name: Check | ||
run: | | ||
cargo build --no-default-features --target aarch64-unknown-none | ||
cargo check --examples --no-default-features --target aarch64-unknown-none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the other structure, while changing the target to aarch64-unknown-none
?
@@ -75,31 +75,23 @@ jobs: | |||
uses: actions-rs/cargo@v1 | |||
with: | |||
command: check | |||
args: --all-features --examples --workspace --benches | |||
args: --all-features --examples --all --benches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe --all
is deprecated
args: "--workspace \ | ||
--all-features \ | ||
--exclude ark-poly-benches" | ||
args: "--all \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
args: "--all \ | |
args: "--workspace \ |
@@ -33,7 +33,7 @@ jobs: | |||
name: Test | |||
runs-on: ubuntu-latest | |||
env: | |||
RUSTFLAGS: -Dwarnings | |||
RUSTFLAGS: -Dwarnings --cfg ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does --cfg ci
do?
When adding the CI for PCD and IVLS, I revisit this document.
I made some changes based on the CI.yml of
nonnative
but I am not sure if they are appropriate for the template.Thoughts?