Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the ARM for check_std #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 9 additions & 24 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
name: Test
runs-on: ubuntu-latest
env:
RUSTFLAGS: -Dwarnings
RUSTFLAGS: -Dwarnings --cfg ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does --cfg ci do?

strategy:
matrix:
rust:
Expand Down Expand Up @@ -75,31 +75,23 @@ jobs:
uses: actions-rs/cargo@v1
with:
command: check
args: --all-features --examples --workspace --benches
args: --all-features --examples --all --benches
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe --all is deprecated

if: matrix.rust == 'nightly'

- name: Test
uses: actions-rs/cargo@v1
with:
command: test
args: "--workspace \
--all-features \
--exclude ark-poly-benches"
args: "--all \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
args: "--all \
args: "--workspace \

--all-features"

check_no_std:
name: Check no_std
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Install Rust (${{ matrix.rust }})
uses: actions-rs/toolchain@v1
with:
toolchain: stable
target: thumbv6m-none-eabi
override: true


- name: Install Rust ARM64 (${{ matrix.rust }})
uses: actions-rs/toolchain@v1
with:
Expand All @@ -115,14 +107,7 @@ jobs:
target
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}

- name: check
uses: actions-rs/cargo@v1
with:
command: check
args: --examples --workspace --exclude ark-poly-benches --target thumbv6m-none-eabi

- name: build
uses: actions-rs/cargo@v1
with:
command: build
args: --workspace --exclude ark-poly-benches --target thumbv6m-none-eabi
- name: Check
run: |
cargo build --no-default-features --target aarch64-unknown-none
cargo check --examples --no-default-features --target aarch64-unknown-none
Comment on lines +110 to +113
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the other structure, while changing the target to aarch64-unknown-none?