Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed initRemoteConfig method #824

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

kurtsergey
Copy link
Contributor

Fixed misconception about inititalization/activation

Fixed misconception about inititalization/activation
@soumak77
Copy link
Contributor

soumak77 commented Sep 5, 2018

@kurtsergey I feel this change should depend on a configuration variable so that it can be turned on/off based the the app's requirements. Some apps may depend on this functionality, so we can't just remove it entirely.

@kurtsergey
Copy link
Contributor Author

@soumak77 Apps cannot depend on this functionality because there is no 'init' functionality in native RemoteConfig modules.

@soumak77
Copy link
Contributor

soumak77 commented Sep 5, 2018

@kurtsergey understood. Does this fix any open issues that can be closed once merged?

@kurtsergey
Copy link
Contributor Author

No, I cannot find any issues about it.

@soumak77 soumak77 merged commit 9939f3c into arnesson:master Sep 5, 2018
@kurtsergey
Copy link
Contributor Author

@soumak77 Would you please publish release?

@soumak77
Copy link
Contributor

soumak77 commented Sep 7, 2018 via email

@herrskytte
Copy link

I get RemoteConfig isn't initalised...
Got the same for analytics, performance etc but fixed it with initX. But there should be initRemoteConfig too?

Get the error when calling setConfigSettings(..)

@briantq
Copy link
Contributor

briantq commented Sep 10, 2018

@herrskytte the analytics and performance inits are still in the latest version of the plugin. These were added by accident as they change the defualt behavior of this plugin. We are working on reverting the code so users don't have to call in init method.

We have a pull request to remove them so if you could test and confirm if this resolves the issue, that would be great. You can do this by:

  1. Remove your initX in your code
  2. cordova plugin remove cordova-pluin-firebase
  3. cordova plugin add https://github.com/briantq/cordova-plugin-firebase.git#revert-lazy-init

If you could test with that branch and confirm that it works as expected, that would help us in merging the fix faster.

@herrskytte
Copy link

@briantq I am working behind a firewall, so I can only access Maven, not Github. Sorry.

Sidenote: Yesterday I only got the error about RemoteConfig, but after resetting the platform the app now crashes on startup with a Java IllegalStateException: FirebaseApp is not initialized in this process .. Make sure to call FirebaseApp.initializeApp(Context) first. I get this both with and without the initX code

@briantq
Copy link
Contributor

briantq commented Sep 11, 2018

@herrskytte Can you run cordova plugin list to see which version of the plugin you are using? Make sure you are using 2.X and you shouldn't hit that error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants