This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Fix asKotlin extension function to just working with fqName #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aballano
approved these changes
May 29, 2020
arrow-meta/src/main/java/arrow/meta/encoder/jvm/StringTypeExtensions.kt
Outdated
Show resolved
Hide resolved
…nsions.kt Co-authored-by: Alberto Ballano <aballano@users.noreply.github.com>
raulraja
changed the title
raulraja
approved these changes
May 29, 2020
|
thanks @hadilq ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #129 PR there is a problem that
arrow-metaconvertsjava.lang.Classtokotlin.Class, which does not exist. This is happening because theasKotlinextension function tries to convert the packageName alone. In this PR both packageName and simpleName are depending to fqName andasKotlinjust converts fqName without generally guessing the corresponding kotlin dual of classes.This solution can have more impact if I would removed all the packageName.asKotlin() and simpleName.asKotlin() in the code, but I would do that if this approach be acceptable one by reviewers.