Add logic in interceptor to update routing table from ConfigMap #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
arschles
changed the title
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
29 tasks
…nto new-routing-table-interceptor Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
arschles
commented
Aug 12, 2021
|
|
||
| operatorRoutingFetchURL, err := operatorCfg.RoutingFetchURL() |
There was a problem hiding this comment.
TODO: take old interceptor configurations out of helm chart
arschles
commented
Aug 12, 2021
pkg/routing/config_map.go
Outdated
| return ret, nil | ||
| } | ||
|
|
||
| // GetTable fetches a table via an RPC call to operatorAdminURL, replaces the |
There was a problem hiding this comment.
TODO: this comment is outdated. fix it
arschles
commented
Aug 12, 2021
| q queue.Counter, | ||
| ) error { | ||
| lggr = lggr.WithName("pkg.routing.StartConfigMapRoutingTableUpdater") | ||
| watchIface, err := getterWatcher.Watch(ctx, metav1.ListOptions{}) |
There was a problem hiding this comment.
TODO: cancel the watch in a defer
arschles
commented
Aug 12, 2021
|
|
||
| case evt := <-watchIface.ResultChan(): | ||
| evtType := evt.Type | ||
| obj := evt.Object |
There was a problem hiding this comment.
TODO: check the name of the configmap
arschles
commented
Aug 12, 2021
pkg/routing/config_map_updater.go
Outdated
| evtType := evt.Type | ||
| obj := evt.Object | ||
| if evtType == watch.Added || evtType == watch.Modified { | ||
| cm := obj.(*corev1.ConfigMap) |
There was a problem hiding this comment.
TODO: check that the type assertion succeeded
arschles
commented
Aug 12, 2021
| if err != nil { | ||
| return err | ||
| } | ||
| table.Replace(newTable) |
There was a problem hiding this comment.
TODO: update the queue with the hosts in the new table
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
arschles
added a commit
that referenced
this pull request
Aug 18, 2021
Co-authored-by: Lucas Santos <lhs.santoss@gmail.com> Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #10 to be merged before this can be