Artist Auction Results App, make filter state track page number and cursor. #5648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artsyjian
changed the title
Error RangeErrorDangerfile |
zephraph
reviewed
May 26, 2020
Comment on lines
-65
to
-92
| const loadAfter = cursor => { | ||
| setIsLoading(true) | ||
| togglePaginated(true) | ||
|
|
||
| relay.refetch( | ||
| { | ||
| first: PAGE_SIZE, | ||
| after: cursor, | ||
| artistID: artist.slug, | ||
| before: null, | ||
| last: null, | ||
| organizations, | ||
| categories, | ||
| sizes, | ||
| sort, | ||
| createdBeforeYear, | ||
| createdAfterYear, | ||
| allowEmptyCreatedDates, | ||
| }, | ||
| null, | ||
| error => { | ||
| setIsLoading(false) | ||
|
|
||
| if (error) { | ||
| logger.error(error) | ||
| } | ||
| } | ||
| ) |
There was a problem hiding this comment.
This is such a huge improvement 🙌.
zephraph
reviewed
May 26, 2020
Comment on lines
+186
to
+188
| if (filterState.pageAndCursor.page === 1) { | ||
| filterState.pageAndCursor.cursor = null | ||
| } |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://artsyproduct.atlassian.net/browse/PURCHASE-1927
To make filter state track current page and cursor. So that we can really rely on filter state to determine whether any filters (including page#) has changed.
In filter state, replaced
pageproperty with an object containingpageandcursor. The two must be updated together due to the wayReducerworks.cursoris really what is used for data fetching.paginatedstate is removed. It was a work-around because filter state didn't track page (it was always 1).The relay fetch code block in
loadAfter()was required to trigger refetch due to pagination. Now it isn't anymore. Now, pagination triggers filter state difference which triggers relay fetch inuseDeepCompareEffect.