Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open Builder for subtypes #143

Open
bastie opened this issue Jul 12, 2024 · 1 comment
Open

open Builder for subtypes #143

bastie opened this issue Jul 12, 2024 · 1 comment
Assignees

Comments

@bastie
Copy link

bastie commented Jul 12, 2024

Hello,
nice project.

Please do not Iban.Builder as final and declare fillMissingFieldsRandomly as protected, because generation of random Iban are rare correct with more checks. For example:

Germanys IBAN checksum maybe correct, but in 100_000 random cycles generates less than 10 times "more" correct IBAN. German IBAN contains the old Bankleitzahl after the checksum. The Bundesbank provides 4 times a year a list of valid Bankleitzahl. And so today's random generate IBAN for CountryCode DE is rare valid.
The Bankleitzahl is not the only check for German IBAN, because after that number came the Kontonummer and the Kontonummer include also a checksum depending of Bankleitzahl before.
See https://www.bundesbank.de/de/aufgaben/unbarer-zahlungsverkehr/serviceangebot/iban-regeln

If you open the Iban.Builder more accurate random build can be direct implemented.

with regards

@hajk1
Copy link
Collaborator

hajk1 commented Jul 12, 2024

Hello @bastie, thanks for your comment. I'll consider your points.

@hajk1 hajk1 self-assigned this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants