Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interface DragEventCallback missing alternative void return type #150

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

artus9033
Copy link
Owner

Describe your changes

Typings for DragEventCallback requires that a callback returns boolean, while it should be boolean | void to allow for not returning anything for simplicity.

Linked issues (if any)

N/A

Checklist before requesting a review

  • E2E tests' snapshots (screenshots) are up-to-date
  • documentation is up-to-date

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (9214884) to head (171307d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files          11       11           
  Lines         228      228           
  Branches      109      109           
=======================================
  Hits          220      220           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artus9033 artus9033 merged commit 91dc179 into master Aug 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant