-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add from_turing
and from_soss
to simplify getting auxiliary groups
#132
Comments
Thanks @sethaxen . I love the idea of cutting down boilerplate. In Julia it seems like we wouldn't need separate function names, since it could just dispatch on the types. Do you prefer not to do that to have the call syntax more similar to the Python version, or are there other reasons to do it this way? Also maybe worth mentioning that in Soss we can manipulate the model to return things other than the samples themselves. So for example, instead of returning a sample from some distribution, we can return the distribution itself. For posterior predictive checks you then get a collection of distributions (one for each posterior sample), and you can do things like evaluate the quantile of the observed data for each value. We don't need to cover all of that immediately, just mentioning it in case it helps in planning how this is designed. |
This is a good question. The current interface is very Pythonic, to parallel the Python package. So currently the
So long as we dispatch to Python, I probably won't do anything with this, but perhaps when we do #128, then we can release some constraints on what a sample should be and revisit this. |
As demonstrated in the Quickstart, generating prior, prior predictive, and posterior predictive samples for Turing and Soss, as well as log-likelihood values for Turing, is mostly boiler plate code that can be copied from the Quickstart by the user. We could eliminate the boiler plate for the user by adding
from_turing
andfrom_soss
converters that take posterior samples as the first argument and an optionalmodel
keyword, e.g.arviz.from_pymc3
takes a similarmodel
keyword, which (I think) it only uses to compute log-likelihoods.cc @cscherrer, @torfjelde
The text was updated successfully, but these errors were encountered: