Merge pull request cake-build#1012 from devlead/feature/cake-buildGH-974

GH974: Supress obsolete warnings from generated code

src/Cake.Core.Tests/Unit/Scripting/CodeGen/Expected/Methods/Obsolete_ExplicitWarning_WithMessage

@@ -1,5 +1,7 @@
 public void Obsolete_ExplicitWarning_WithMessage()
 {
     Context.Log.Warning("Warning: The alias Obsolete_ExplicitWarning_WithMessage has been made obsolete. Please use Foo.Bar instead.");
+#pragma warning disable 0618
     Cake.Core.Tests.Data.MethodAliasGeneratorData.Obsolete_ExplicitWarning_WithMessage(Context);
+#pragma warning restore 0618
 }

src/Cake.Core.Tests/Unit/Scripting/CodeGen/Expected/Methods/Obsolete_ImplicitWarning_NoMessage

@@ -1,5 +1,7 @@
 public void Obsolete_ImplicitWarning_NoMessage()
 {
     Context.Log.Warning("Warning: The alias Obsolete_ImplicitWarning_NoMessage has been made obsolete.");
+#pragma warning disable 0618
     Cake.Core.Tests.Data.MethodAliasGeneratorData.Obsolete_ImplicitWarning_NoMessage(Context);
+#pragma warning restore 0618
 }

src/Cake.Core.Tests/Unit/Scripting/CodeGen/Expected/Methods/Obsolete_ImplicitWarning_WithMessage

@@ -1,5 +1,7 @@
 public void Obsolete_ImplicitWarning_WithMessage()
 {
     Context.Log.Warning("Warning: The alias Obsolete_ImplicitWarning_WithMessage has been made obsolete. Please use Foo.Bar instead.");
+#pragma warning disable 0618
     Cake.Core.Tests.Data.MethodAliasGeneratorData.Obsolete_ImplicitWarning_WithMessage(Context);
+#pragma warning restore 0618
 }

src/Cake.Core/Scripting/CodeGen/MethodAliasGenerator.cs

@@ -55,7 +55,8 @@ public static string Generate(MethodInfo method)
 
             // Method is obsolete?
             var obsolete = method.GetCustomAttribute<ObsoleteAttribute>();
-            if (obsolete != null)
+            var isObsolete = obsolete != null;
+            if (isObsolete)
             {
                 var message = GetObsoleteMessage(method, obsolete);
 
@@ -79,6 +80,11 @@ public static string Generate(MethodInfo method)
                     "    Context.Log.Warning(\"Warning: {0}\");", message));
             }
 
+            if (isObsolete)
+            {
+                builder.AppendLine("#pragma warning disable 0618");
+            }
+
             builder.Append("    ");
 
             if (isFunction)
@@ -101,6 +107,11 @@ public static string Generate(MethodInfo method)
             builder.Append(");");
             builder.AppendLine();
 
+            if (isObsolete)
+            {
+                builder.AppendLine("#pragma warning restore 0618");
+            }
+
             // End method.
             builder.Append("}");
             builder.AppendLine();