Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting base_font_style has no effect #373

Closed
iwrigley opened this issue Dec 15, 2015 · 3 comments
Closed

Setting base_font_style has no effect #373

iwrigley opened this issue Dec 15, 2015 · 3 comments
Assignees

Comments

@iwrigley
Copy link

Setting the base_font_style attribute has no effect out the output PDF. Tested in 1.5.0.alpha.10.

Test to reproduce:

[10:41am] ~/Desktop/basefontdemo ian@ianmbp% cat testdoc.adoc
= Test *document*: this all comes out bold, as it should

This line should be *bold*, but only the explicitly-styled word is actually bold in the output PDF.

[10:44am] ~/Desktop/basefontdemo ian@ianmbp% cat themes/test-theme.yml
base:
  font_family: Helvetica
  font_color: 000000
  font_size: 20pt
  font_style: bold

title_page:
  font_style: bold

[10:44am] ~/Desktop/basefontdemo ian@ianmbp% asciidoctor-pdf --version
Asciidoctor PDF 1.5.0.alpha.10 using Asciidoctor 1.5.3 [http://asciidoctor.org]
Runtime Environment (ruby 2.2.1p85 (2015-02-26 revision 49769) [x86_64-darwin14]) (lc:UTF-8 fs:UTF-8 in:- ex:UTF-8)

[10:44am] ~/Desktop/basefontdemo ian@ianmbp% asciidoctor-pdf -a pdf-stylesdir=themes -a pdf-style=test testdoc.adoc
@mojavelinux
Copy link
Member

Right you are. For some reason, we weren't applying the base_font_style. I've sent a pull request to implement this change.

@iwrigley
Copy link
Author

Dan

Thank you! You're doing an amazing job with Asciidoctor and Asciidoctor-pdf. It's really appreciated.

@mojavelinux
Copy link
Member

Thanks @iwrigley!

Tons of that credit goes to the Asciidoctor supporters, who enable me to work on Asciidoctor each day. https://salt.bountysource.com/teams/asciidoctor

@mojavelinux mojavelinux added this to the v1.5.0.beta.1 milestone Dec 16, 2015
mojavelinux added a commit that referenced this issue Dec 16, 2015
resolves #373 apply base font style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants