Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(usecase/nodecli): Rest/Spreadプロパティを使って書き直し #351

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

lacolaco
Copy link
Collaborator

@lacolaco lacolaco commented Feb 1, 2018

#7

ref: #349

@bot-user
Copy link

bot-user commented Feb 1, 2018

Deploy preview for js-primer ready!

Built with commit 7d47a70

https://deploy-preview-351--js-primer.netlify.com

@lacolaco
Copy link
Collaborator Author

lacolaco commented Feb 1, 2018

構文に対応してない? Node 8の環境でも落ちてる

@lacolaco
Copy link
Collaborator Author

lacolaco commented Feb 1, 2018

eslintが落ちてるっぽい

@lacolaco
Copy link
Collaborator Author

lacolaco commented Feb 1, 2018

https://eslint.org/docs/user-guide/configuring#specifying-parser-options
experimentalObjectRestSpread が必要そう

Copy link
Collaborator

@azu azu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lacolaco lacolaco merged commit 97a1e38 into master Feb 2, 2018
@lacolaco lacolaco deleted the nodecli-rest-properties branch February 2, 2018 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants