Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin zarr #43

Merged
merged 3 commits into from
May 28, 2024
Merged

pin zarr #43

merged 3 commits into from
May 28, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented May 24, 2024

Zarr v3 is planned for release in June: zarr-developers/zarr-python#1777
It includes major API changes which will break this extension (see https://github.com/asdf-format/asdf-zarr/actions/runs/9227086826/job/25388325700).

This PR pins zarr to "<3" and removes it from the devdeps (so that we can at least test our other dependencies).

Once the v3 API is finalized this package can be updated to possibly support both <3 and >=3 versions or support for <3 can be dropped.

@braingram braingram marked this pull request as ready for review May 24, 2024 16:49
@braingram braingram requested a review from a team as a code owner May 24, 2024 16:49
@braingram braingram requested a review from zacharyburnett May 24, 2024 16:49
Copy link
Member

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and if people want zarr to be included in the devdeps they can uncomment the line in requirements-dev.txt

@braingram braingram merged commit 4015d49 into asdf-format:main May 28, 2024
16 checks passed
@braingram braingram deleted the pin_zarr branch May 28, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants