Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TimeWindow not resetting buckets when re-using them. #14

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

MathiasGr
Copy link
Contributor

Fixes #13

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #14 (975d3d0) into master (fe8c9d1) will increase coverage by 1.65%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   91.95%   93.60%   +1.65%     
==========================================
  Files           4        4              
  Lines         174      219      +45     
==========================================
+ Hits          160      205      +45     
  Misses          9        9              
  Partials        5        5              
Impacted Files Coverage Δ
time.go 100.00% <100.00%> (ø)
point.go 100.00% <0.00%> (ø)
window.go 100.00% <0.00%> (ø)
reduce.go 90.66% <0.00%> (+1.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe8c9d1...975d3d0. Read the comment docs.

Copy link
Contributor

@ensary ensary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MathiasGr !

@nkhan-atlassian
Copy link

looks good to me. Thank you for adding in that bucket reset!

@ensary ensary merged commit 1a3fec5 into asecurityteam:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeWindow Policy does not expire old values
3 participants