Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error if Igniter is installed as a non-dev dependency #208

Open
sevenseacat opened this issue Jan 25, 2025 · 3 comments
Open

Raise an error if Igniter is installed as a non-dev dependency #208

sevenseacat opened this issue Jan 25, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@sevenseacat
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I added Igniter to one of my projects to use it, via adding to the mix.exs file:

{:igniter, "~> 0.5"}

This worked to install Ash, but then errored because Ash installs sourcerer as a dev/test-only dependency, whereas Igniter needs it as a full dependency.

Igniter should not be installed this way, as I learned - it should only ever be a dev dependency (and doesn't even need to be added to your deps to use it if the igniter_new archive is installed).

Describe the solution you'd like

Igniter should raise an error if it is detected that it is installed incorrectly. This should be possible to do!

@sevenseacat sevenseacat added the enhancement New feature or request label Jan 25, 2025
@zachdaniel zachdaniel moved this to Someday in Ash Framework Roadmap Jan 25, 2025
@zachdaniel
Copy link
Contributor

I've put this into the "Someday" category because all of the current guides and processes make it a dev/test dep, but this is a nice to have in case its not set up properly in a project 😄

@ken-kost
Copy link

This should be possible to do!

I tried to figure out how; failed. 😖
Seems to me key information here is the project's env from which the dep is called.
Is that even possible to get from inside the dep igniter? Feels like it isn't. idk 🐛

@zachdaniel
Copy link
Contributor

The there isn't really a good way, thinking about it. Maybe the best thing to do is call something out in the getting started guide. "Make sure that igniter..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Someday
Development

No branches or pull requests

3 participants