-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fuchsia support #626
Add Fuchsia support #626
Conversation
Use the proper name for `libvulkan.so` on Fuchsia.
https://doc.rust-lang.org/reference/conditional-compilation.html#target_os I'm surprised the official docs don't mention the existence of |
Co-authored-by: Marijn Suijten <marijns95@gmail.com>
Fuchsia is a Tier 2 supported OS for Rust: https://doc.rust-lang.org/rustc/platform-support.html#tier-2 For context, I'm a Fuchsia OS developer. We'd like to switch over from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fuchsia doesn't do the unixy .so.$MAJOR
thing? Interesting; is this documented anywhere? Any way we can sensibly cover this in CI?
Note that if you build ash with |
Yes, we do that for most shared libraries. I'm not sure why
Not yet. We're working on that as part of our quest for Tier 1 support in Rust.
Ok, I'll give that a try. |
Hmm, are you using the standard Khronos Vulkan loader? This may be a bug in the upstream build system, if so. I'm not entirely clear on the significance of respecting that pattern vs. not, but I figure it's probably worth being consistent with the system at large. |
@abarth any update on not using/having a |
Looking at the linked Fuchsia docs it's still |
For |
Use the proper name for
libvulkan.so
on Fuchsia.