Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlap margin calculation. #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rasky
Copy link

@rasky rasky commented Dec 6, 2023

The current code is only called when a new compressed byte is read, not after the corresponding decompressed bytes are written. This means that the contents produced by the last byte of input are not taken into account, which can make a huge difference for instance on files with long sequences of zeros at the end.

The current code is only called when a new compressed byte is read,
not after the corresponding decompressed bytes are written. This
means that the contents produced by the last byte of input are not
taken into account, which can make a huge difference for instance on
files with long sequences of zeros at the end.
rasky added a commit to rasky/libdragon that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant