Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node has negative length #116

Closed
rlorigro opened this issue Sep 2, 2022 · 7 comments · Fixed by #117
Closed

Node has negative length #116

rlorigro opened this issue Sep 2, 2022 · 7 comments · Fixed by #117
Milestone

Comments

@rlorigro
Copy link

rlorigro commented Sep 2, 2022

When loading this graph:
https://rlorigro-public-files.s3.us-west-1.amazonaws.com/gfase/verkko/full_coverage/bandage_error.gfa

I get this result in the latest release of BandageNG:
image

It looks like this in original Bandage:
image

@asl
Copy link
Owner

asl commented Sep 4, 2022

Nice catch! Bandage legacy code uses signed integers everywhere... And this causes sometimes fun stuff like this. Will fix.

@rlorigro
Copy link
Author

rlorigro commented Oct 4, 2022

Hi, just checking in, are there plans for an October release that includes this fix? It seems to be a very persistent error in Verkko graphs

@asl
Copy link
Owner

asl commented Oct 4, 2022

@rlorigro Oh, sorry, yes! Was pretty busy recently... This reminds me that we'd likely simply need rolling releases :)

@rlorigro
Copy link
Author

rlorigro commented Oct 4, 2022

Ok, no problem, looking forward to switching over 👍

@rlorigro
Copy link
Author

just another bi-monthly check in on this..

@asl
Copy link
Owner

asl commented Oct 18, 2022

@rlorigro I wanted to also make windows snapshots for 2022.10 release... but probably I'd just make a snapshot soon ;)

@asl
Copy link
Owner

asl commented Oct 24, 2022

@rlorigro Here we go: https://github.com/asl/BandageNG/releases/tag/v2022.09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants