From 625990fb85164fc623ede643203eda6309f38d4e Mon Sep 17 00:00:00 2001
From: Jan Vincent Liwanag <jvliwanag@gmail.com>
Date: Thu, 12 Oct 2023 16:35:21 +0800
Subject: [PATCH] Add sample ts_proto wrong output placement

* Moved eliza.proto and proto_library one level up
* Adjusted references on BUILD from proto dir
* Now fails to build

$ bazel build //examples/connect_node/proto

Error in declare_file: the output artifact 'examples/connect_node/eliza_pb.js' is not under package directory 'examples/connect_node/proto' for target '//examples/connect_node/proto:eliza_ts_proto'
---
 examples/connect_node/BUILD.bazel             | 7 +++++++
 examples/connect_node/{proto => }/eliza.proto | 0
 examples/connect_node/proto/BUILD.bazel       | 8 +-------
 3 files changed, 8 insertions(+), 7 deletions(-)
 rename examples/connect_node/{proto => }/eliza.proto (100%)

diff --git a/examples/connect_node/BUILD.bazel b/examples/connect_node/BUILD.bazel
index 150e88c2..d97d8857 100644
--- a/examples/connect_node/BUILD.bazel
+++ b/examples/connect_node/BUILD.bazel
@@ -1,6 +1,7 @@
 load("@aspect_rules_js//js:defs.bzl", "js_binary")
 load("@aspect_rules_ts//ts:defs.bzl", "ts_project")
 load("@npm//:defs.bzl", "npm_link_all_packages")
+load("@rules_proto//proto:defs.bzl", "proto_library")
 
 npm_link_all_packages()
 
@@ -34,3 +35,9 @@ js_binary(
     ],
     entry_point = "server.js",
 )
+
+proto_library(
+    name = "eliza_proto",
+    srcs = ["eliza.proto"],
+    visibility = ["//visibility:public"],
+)
diff --git a/examples/connect_node/proto/eliza.proto b/examples/connect_node/eliza.proto
similarity index 100%
rename from examples/connect_node/proto/eliza.proto
rename to examples/connect_node/eliza.proto
diff --git a/examples/connect_node/proto/BUILD.bazel b/examples/connect_node/proto/BUILD.bazel
index 39375b39..f814b938 100644
--- a/examples/connect_node/proto/BUILD.bazel
+++ b/examples/connect_node/proto/BUILD.bazel
@@ -1,18 +1,12 @@
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 load("@aspect_rules_ts//ts:proto.bzl", "ts_proto_library")
-load("@rules_proto//proto:defs.bzl", "proto_library")
 
 package(default_visibility = ["//visibility:public"])
 
-proto_library(
-    name = "eliza_proto",
-    srcs = ["eliza.proto"],
-)
-
 ts_proto_library(
     name = "eliza_ts_proto",
     node_modules = "//examples/connect_node:node_modules",
-    proto = ":eliza_proto",
+    proto = "//examples/connect_node:eliza_proto",
 )
 
 js_library(