Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Interop with 4.5 (doc/sample story) #682

Closed
HaoK opened this issue Dec 16, 2015 · 17 comments
Closed

Interop with 4.5 (doc/sample story) #682

HaoK opened this issue Dec 16, 2015 · 17 comments
Assignees
Labels
Milestone

Comments

@HaoK
Copy link
Member

HaoK commented Dec 16, 2015

Need to clean up a few things still:

  • Add initial EF6 migration
  • Add code to do property updating of normalized columns as part of SaveChanges
@HaoK HaoK added the Samples label Dec 16, 2015
@HaoK HaoK added this to the 3.0.0-rc2 milestone Dec 16, 2015
@HaoK HaoK self-assigned this Dec 16, 2015
@divega divega modified the milestones: 1.0.0, 1.0.0-rc2 Apr 1, 2016
@HaoK
Copy link
Member Author

HaoK commented Apr 4, 2016

@HaoK
Copy link
Member Author

HaoK commented Apr 20, 2016

Desired flow:

  • Create 4.5.1 MVC App (Run + Create user + login) => Mimics Initial V2 schema
  • Run Enable-Migrations and ensure that an initial migration is created
  • Install AspNet.Identity.CoreCompat and include the compat namespace to rebase the Identity POCO
  • Run migrations using EF6 to update schema to V3
  • Run Core Identity app and verify that login works against database
  • Final step: Update both apps to use the same dataprotection so cookies are shared cross app

@divega
Copy link

divega commented Apr 20, 2016

@HaoK Remember that before you drop the new classes and rebase you have to make sure you have enabled migrations.

@HaoK
Copy link
Member Author

HaoK commented Jun 13, 2016

Interop sample can't live in same sln as core currently due to package restore issues and ef migrations. Will need to revisit what we want to do (if anything) Could just have a blog post/doc walkthrough instead of a checked in sample since its more of a flow anyways

@HaoK
Copy link
Member Author

HaoK commented Jun 13, 2016

Moving to 1.0.1 since there's nothing to be done in 1.0.0

@HaoK HaoK modified the milestones: 1.0.1, 1.0.0 Jun 13, 2016
@divega
Copy link

divega commented Jun 13, 2016

Could just have a blog post/doc walkthrough instead of a checked in sample since its more of a flow anyways

Another option would be to put it into its own repo.

@HaoK
Copy link
Member Author

HaoK commented Jun 13, 2016

The main problem is that the best I can do is check in a snapshot at a single point (probably the end result) of the migration.

@HaoK
Copy link
Member Author

HaoK commented Jun 13, 2016

Also its weird for it to live in its own repo when the Compat package lives here

@HaoK
Copy link
Member Author

HaoK commented Jun 13, 2016

I think a second sln in this repo would be better than moving it out

@HaoK HaoK changed the title Flesh out the interop sample Interop with 4.5 (doc/sample story) Jul 1, 2016
@HaoK HaoK removed the Samples label Jul 1, 2016
@HaoK
Copy link
Member Author

HaoK commented Aug 23, 2016

Related dotnet/efcore#2167

@danroth27
Copy link
Member

@divega @HaoK Microsoft Customer Support Services reported that customers are having issues setting up cookie sharing and could use a fully functional sample. How soon can we get the sample updated so that we can link to it from the docs?

@HaoK
Copy link
Member Author

HaoK commented Aug 30, 2016 via email

@divega
Copy link

divega commented Aug 30, 2016

@danroth27 we can make this a high priority as per our conversation, but can you please answer about the scope (cooking sharing vs. full with a shared database)?

@divega divega modified the milestones: 1.1.0, 1.1.0-preview1 Oct 12, 2016
@HaoK
Copy link
Member Author

HaoK commented Nov 3, 2016

@blowdart is working on the updated example/sample doc in his private repo

@HaoK HaoK assigned blowdart and unassigned HaoK Nov 3, 2016
@divega divega modified the milestones: 1.2.0, 1.1.0 Nov 9, 2016
@divega
Copy link

divega commented Nov 9, 2016

@HaoK @blowdart moving this to 1.2 because it doesn't seem to be something that would block use from shipping 1.1 at this point.

@Eilon
Copy link
Member

Eilon commented Mar 6, 2018

@blowdart / @HaoK / @divega - this bug is ~1.5 years old, should we just close it?

@HaoK
Copy link
Member Author

HaoK commented Mar 6, 2018

yeah its already sorta covered by https://docs.microsoft.com/en-us/aspnet/core/security/data-protection/compatibility/cookie-sharing?tabs=aspnetcore2x and there are issues tracking improving that to target interop

@HaoK HaoK closed this as completed Mar 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants