Skip to content
This repository was archived by the owner on Dec 20, 2018. It is now read-only.

Conversation

@HaoK
Copy link
Member

@HaoK HaoK commented Mar 3, 2017

No description provided.

@HaoK HaoK changed the title Initial compilation changes for identity + Auth 2.0 Prototype: Initial compilation changes for identity + Auth 2.0 Mar 3, 2017
@HaoK HaoK force-pushed the haok/auth2 branch 2 times, most recently from d453e4e to a9f75e5 Compare March 9, 2017 00:42
@HaoK
Copy link
Member Author

HaoK commented Apr 12, 2017

@Tratcher @ajcvickers These are the initial identity changes needed for Auth 2.0, mostly switching from direct configuration of cookie options instances that live inside of identity options, to configuring them via fixed names. MVC needs to be updated as well before Identity.Sample can be updated.

@HaoK HaoK changed the title Prototype: Initial compilation changes for identity + Auth 2.0 Auth/Options 2.0 + Identity Apr 12, 2017
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty strait forward

/// </summary>
/// <param name="app">The <see cref="IApplicationBuilder"/> instance this method extends.</param>
/// <returns>The <see cref="IApplicationBuilder"/> instance this method extends.</returns>
public static IApplicationBuilder UseIdentity(this IApplicationBuilder app)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to come back as obsolete with the fwlink right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah good catch this PR was created before we decided to do that, I'll restore with obsolete

/// <param name="options">Used to access the <see cref="IdentityOptions"/>.</param>
/// <param name="signInManager">The <see cref="SignInManager{TUser}"/>.</param>
public SecurityStampValidator(IOptions<IdentityOptions> options, SignInManager<TUser> signInManager)
/// <param name="clock">The system clock.</param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the internal one from Security?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its no longer internal, since you can implement your own ISystemClock and add it to the container (what we do for tests). But yeah its definied in the Security/Authentication package

@HaoK
Copy link
Member Author

HaoK commented Apr 19, 2017

14b4bea

@HaoK HaoK closed this Apr 19, 2017
@HaoK HaoK deleted the haok/auth2 branch August 7, 2017 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants