-
Notifications
You must be signed in to change notification settings - Fork 853
Auth/Options 2.0 + Identity #1119
Conversation
d453e4e to
a9f75e5
Compare
|
@Tratcher @ajcvickers These are the initial identity changes needed for Auth 2.0, mostly switching from direct configuration of cookie options instances that live inside of identity options, to configuring them via fixed names. MVC needs to be updated as well before Identity.Sample can be updated. |
Tratcher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty strait forward
| /// </summary> | ||
| /// <param name="app">The <see cref="IApplicationBuilder"/> instance this method extends.</param> | ||
| /// <returns>The <see cref="IApplicationBuilder"/> instance this method extends.</returns> | ||
| public static IApplicationBuilder UseIdentity(this IApplicationBuilder app) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to come back as obsolete with the fwlink right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah good catch this PR was created before we decided to do that, I'll restore with obsolete
| /// <param name="options">Used to access the <see cref="IdentityOptions"/>.</param> | ||
| /// <param name="signInManager">The <see cref="SignInManager{TUser}"/>.</param> | ||
| public SecurityStampValidator(IOptions<IdentityOptions> options, SignInManager<TUser> signInManager) | ||
| /// <param name="clock">The system clock.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the internal one from Security?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its no longer internal, since you can implement your own ISystemClock and add it to the container (what we do for tests). But yeah its definied in the Security/Authentication package
No description provided.