From 1176df8c2513e01d6a728d9d1c8e3a89630f42fe Mon Sep 17 00:00:00 2001 From: Aaron Powell Date: Sun, 7 Aug 2016 22:02:00 +1000 Subject: [PATCH 1/2] Correcting path separator to ; --- .../HostingModels/OutOfProcessNodeInstance.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs b/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs index e85ed8c1..b3cc70d4 100644 --- a/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs +++ b/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs @@ -126,7 +126,7 @@ protected virtual ProcessStartInfo PrepareNodeProcessStartInfo( var existingNodePath = Environment.GetEnvironmentVariable("NODE_PATH") ?? string.Empty; if (existingNodePath != string.Empty) { - existingNodePath += ":"; + existingNodePath += ";"; } var nodePathValue = existingNodePath + Path.Combine(projectPath, "node_modules"); From 64a7d2e0f39009f810ade9abf7d1e4c4e228a225 Mon Sep 17 00:00:00 2001 From: Aaron Powell Date: Sun, 7 Aug 2016 22:15:57 +1000 Subject: [PATCH 2/2] Using the proper API from System.IO to get path separator --- .../HostingModels/OutOfProcessNodeInstance.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs b/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs index b3cc70d4..3c9cfd51 100644 --- a/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs +++ b/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs @@ -126,7 +126,7 @@ protected virtual ProcessStartInfo PrepareNodeProcessStartInfo( var existingNodePath = Environment.GetEnvironmentVariable("NODE_PATH") ?? string.Empty; if (existingNodePath != string.Empty) { - existingNodePath += ";"; + existingNodePath += Path.PathSeparator; } var nodePathValue = existingNodePath + Path.Combine(projectPath, "node_modules");