Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Changes to an excluded file is triggering a restart #90

Closed
kichalla opened this issue May 3, 2016 · 3 comments
Closed

Changes to an excluded file is triggering a restart #90

kichalla opened this issue May 3, 2016 · 3 comments

Comments

@kichalla
Copy link
Member

kichalla commented May 3, 2016

Repro: https://github.com/kichalla/dotnetwatchtestapp/
Git tag: excludedfile_causing_restart

When I change the following excluded Program.cs file, a restart happens

  "buildOptions": {
    "emitEntryPoint": true,
    "compile": {
      "excludeFiles": [
        "temp/Program.cs"
      ]
    }
  }

Expected: restart should not happen and the excluded files should be ignored from being watched
Actual: restart is triggered

@victorhurdugaci
Copy link
Contributor

Interesting, I wonder if it's caused by the recent project.json chances. There's a test already for that and it passes but it uses the old project format:

https://github.com/aspnet/dotnet-watch/blob/dev/test/TestApps/GlobbingApp/project.json#L11

@muratg muratg added the bug label May 9, 2016
@muratg muratg added this to the 1.0.0 milestone May 9, 2016
@muratg
Copy link

muratg commented May 25, 2016

@victorhurdugaci Let's investigate. If it's not a super simple fix, we can move to 1.0.1

@victorhurdugaci
Copy link
Contributor

Just as I suspected, this was caused by the new project structure/reader

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants