Skip to content

Commit

Permalink
scenarios/fork: add nested "remaining universe" test
Browse files Browse the repository at this point in the history
The description for the scenario attempts to explain the utility of the
test.

This was added in response to a question here:
astral-sh/uv#5163 (comment)
  • Loading branch information
BurntSushi committed Jul 25, 2024
1 parent 85f5987 commit 33c2a60
Showing 1 changed file with 47 additions and 0 deletions.
47 changes: 47 additions & 0 deletions scenarios/fork/remaining-universe-partitioning.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name = "fork-remaining-universe-partitioning"
description = '''
This scenario tries to check that the "remaining universe" handling in
the universal resolver is correct. Namely, whenever we create forks
from disjoint markers that don't union to the universe, we need to
create *another* fork corresponding to the difference between the
universe and the union of the forks.
But when we do this, that remaining universe fork needs to be created
like any other fork: it should start copying whatever set of forks
existed by the time we got to this point, intersecting the markers with
the markers describing the remaining universe and then filtering out
any dependencies that are disjoint with the resulting markers.
This test exercises that logic by ensuring that a package `z` in the
remaining universe is excluded based on the combination of markers
from a parent fork. That is, if the remaining universe fork does not
pick up the markers from the parent forks, then `z` would be included
because the remaining universe for _just_ the `b` dependencies of `a`
is `os_name != 'linux' and os_name != 'darwin'`, which is satisfied by
`z`'s marker of `sys_platform == 'windows'`. However, `a 1.0.0` is only
selected in the context of `a < 2 ; sys_platform == 'illumos'`, so `z`
should never appear in the resolution.
'''

[resolver_options]
universal = true

[expected]
satisfiable = true

[root]
requires = [
"a>=2 ; sys_platform == 'windows'",
"a<2 ; sys_platform == 'illumos'",
]

[packages.z.versions."1.0.0"]
[packages.a.versions."1.0.0"]
requires = [
"b>=2 ; os_name == 'linux'",
"b<2 ; os_name == 'darwin'",
"z ; sys_platform == 'windows'",
]
[packages.a.versions."2.0.0"]
[packages.b.versions."1.0.0"]
[packages.b.versions."2.0.0"]

0 comments on commit 33c2a60

Please sign in to comment.