Add a method to retrieve unchanging terms for a package #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When prefetching, we want to avoid prefetching packages we will certainly reject. `PartialSolution::unchanging_term_for_package` returns the terms from root that a certain independent from the current partial solution. See pubgrub-rs#263 (comment)
konstin
added a commit
to astral-sh/uv
that referenced
this pull request
Oct 16, 2024
When batch prefetching we can fetch versions we know that are incompatible. In the following example, we were prefetching sentry-kafka-schemas below version 1.50.0. ``` python-rapidjson<=1.20,>=1.4 sentry-kafka-schemas<=0.1.113,>=0.1.50 ``` Using a new pubgrub interface from astral-sh/pubgrub#32, we can avoid those prefetches by asking for incompatibilities that won't change anymore (those with root).
charliermarsh
approved these changes
Oct 16, 2024
konstin
added a commit
to astral-sh/uv
that referenced
this pull request
Oct 17, 2024
When batch prefetching we can fetch versions we know that are incompatible. In the following example, we were prefetching sentry-kafka-schemas below version 1.50.0. ``` python-rapidjson<=1.20,>=1.4 sentry-kafka-schemas<=0.1.113,>=0.1.50 ``` Using a new pubgrub interface from astral-sh/pubgrub#32, we can avoid those prefetches by asking for incompatibilities that won't change anymore (those with root).
konstin
added a commit
that referenced
this pull request
Oct 24, 2024
konstin
added a commit
that referenced
this pull request
Oct 29, 2024
konstin
added a commit
that referenced
this pull request
Nov 15, 2024
charliermarsh
pushed a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When prefetching, we want to avoid prefetching packages we will certainly reject.
PartialSolution::unchanging_term_for_packagereturns the terms from root that a certain independent from the current partial solution. See pubgrub-rs#263 (comment)