Use execFile rather than spawn
#544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
approved these changes
Jul 19, 2024
MichaReiser
reviewed
Jul 19, 2024
src/common/server.ts
Outdated
| @@ -49,32 +49,15 @@ export type IInitializationOptions = { | |||
| /** | |||
| * Function to execute a command and return the stdout. | |||
| */ | |||
| function executeCommand(cmd: string, args: string[] = []): Promise<string> { | |||
| function executeCommand(file: string, args: string[] = []): Promise<string> { | |||
There was a problem hiding this comment.
Maybe rename to executeFile
charliermarsh
force-pushed
the
charlie/exec
branch
from
8b2fcf7
to
c29764b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recommended in #539.