Merge branch 'main' into dcreager/tuple-spec

* main: (21 commits)
  [`flake8-logging`] Avoid false positive for `exc_info=True` outside `logger.exception` (`LOG014`) (#18737)
  [`flake8-pie`] Small docs fix to `PIE794` (#18829)
  [`pylint`] Ignore __init__.py files in (PLC0414) (#18400)
  Avoid generating diagnostics with per-file ignores (#18801)
  [`flake8-simplify`] Fix false negatives for shadowed bindings  (`SIM910`, `SIM911`) (#18794)
  [ty] Fix panics when pulling types for `ClassVar` or `Final` parameterized with >1 argument (#18824)
  [`pylint`] add fix safety section (`PLR1714`) (#18415)
  [Perflint] Small docs improvement to `PERF401` (#18786)
  [`pylint`] Avoid flattening nested `min`/`max` when outer call has single argument (`PLW3301`) (#16885)
  [`ruff`] Added `cls.__dict__.get('__annotations__')` check (`RUF063`) (#18233)
  [ty] Use `HashTable` in `PlaceTable` (#18819)
  docs: Correct collections-named-tuple example to use PascalCase assignment (#16884)
  [ty] ecosystem-analyzer workflow (#18719)
  [ty] Add support for `@staticmethod`s (#18809)
  unnecessary_dict_kwargs doc - a note on type checking benefits (#18666)
  [`flake8-pytest-style`] Mark autofix for `PT001` and `PT023` as unsafe if there's comments in the decorator (#18792)
  [ty] Surface matched overload diagnostic directly (#18452)
  [ty] Report when a dataclass contains more than one `KW_ONLY` field (#18731)
  [`flake8-pie`] Add fix safety section to `PIE794` (#18802)
  [`pycodestyle`] Add fix safety section to `W291` and `W293`  (#18800)
  ...

Author: dcreager

.github/workflows/ty-ecosystem-analyzer.yaml

@@ -0,0 +1,94 @@
+name: ty ecosystem-analyzer
+
+permissions: {}
+
+on:
+  pull_request:
+    types: [labeled]
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref_name }}-${{ github.event.pull_request.number || github.sha }}
+  cancel-in-progress: true
+
+env:
+  CARGO_INCREMENTAL: 0
+  CARGO_NET_RETRY: 10
+  CARGO_TERM_COLOR: always
+  RUSTUP_MAX_RETRIES: 10
+  RUST_BACKTRACE: 1
+  REF_NAME: ${{ github.ref_name }}
+
+jobs:
+  ty-ecosystem-analyzer:
+    name: Compute diagnostic diff
+    runs-on: depot-ubuntu-22.04-32
+    timeout-minutes: 20
+    if: contains(github.event.label.name, 'ecosystem-analyzer')
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          path: ruff
+          fetch-depth: 0
+          persist-credentials: false
+
+      - name: Install the latest version of uv
+        uses: astral-sh/setup-uv@f0ec1fc3b38f5e7cd731bb6ce540c5af426746bb # v6.1.0
+
+      - uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6 # v2.7.8
+        with:
+          workspaces: "ruff"
+
+      - name: Install Rust toolchain
+        run: rustup show
+
+      - name: Compute diagnostic diff
+        shell: bash
+        run: |
+          cd ruff
+
+          echo "Enabling configuration overloads (see .github/mypy-primer-ty.toml)"
+          mkdir -p ~/.config/ty
+          cp .github/mypy-primer-ty.toml ~/.config/ty/ty.toml
+
+          echo "new commit"
+          git checkout -b new_commit "$GITHUB_SHA"
+          git rev-list --format=%s --max-count=1 new_commit
+          cp crates/ty_python_semantic/resources/primer/good.txt projects_new.txt
+
+          echo "old commit (merge base)"
+          MERGE_BASE="$(git merge-base "$GITHUB_SHA" "origin/$GITHUB_BASE_REF")"
+          git checkout -b old_commit "$MERGE_BASE"
+          git rev-list --format=%s --max-count=1 old_commit
+          cp crates/ty_python_semantic/resources/primer/good.txt projects_old.txt
+
+          cd ..
+
+          uv tool install "git+https://github.com/astral-sh/ecosystem-analyzer@9c34dc514ee9aef6735db1dfebb80f63acbc3440"
+
+          ecosystem-analyzer \
+            --repository ruff \
+            analyze \
+            --projects ruff/projects_old.txt \
+            --commit old_commit \
+            --output diagnostics_old.json
+
+          ecosystem-analyzer \
+            --repository ruff \
+            analyze \
+            --projects ruff/projects_new.txt \
+            --commit new_commit \
+            --output diagnostics_new.json
+
+          ecosystem-analyzer \
+            generate-diff \
+            diagnostics_old.json \
+            diagnostics_new.json \
+            --old-name "main (merge base)" \
+            --new-name "$REF_NAME" \
+            --output-html diff.html
+
+      - name: Upload HTML diff report
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        with:
+          name: diff.html
+          path: diff.html

crates/ruff_linter/resources/test/fixtures/flake8_comprehensions/C401.py

@@ -36,9 +36,19 @@ def f(x):
     # some more
 )
 
+# t-strings
+print(t"Hello {set(f(a) for a in 'abc')} World")
+print(t"Hello { set(f(a) for a in 'abc') } World")
+small_nums = t"{set(a if a < 6 else 0 for a in range(3))}"
+print(t"Hello {set(a for a in range(3))} World")
+print(t"{set(a for a in 'abc') - set(a for a in 'ab')}")
+print(t"{ set(a for a in 'abc') - set(a for a in 'ab') }")
+
+
 # Not built-in set.
 def set(*args, **kwargs):
     return None
 
 set(2 * x for x in range(3))
 set(x for x in range(3))
+

crates/ruff_linter/resources/test/fixtures/flake8_comprehensions/C403.py

@@ -34,4 +34,16 @@ def f(x):
  ))))
 
 # Test trailing comma case
-s = set([x for x in range(3)],)
+s = set([x for x in range(3)],)
+
+s = t"{set([x for x in 'ab'])}"
+s = t'{set([x for x in "ab"])}'
+
+def f(x):
+    return x
+
+s = t"{set([f(x) for x in 'ab'])}"
+
+s = t"{ set([x for x in 'ab']) | set([x for x in 'ab']) }"
+s = t"{set([x for x in 'ab']) | set([x for x in 'ab'])}"
+

crates/ruff_linter/resources/test/fixtures/flake8_comprehensions/C405.py

@@ -24,3 +24,12 @@
 f"{ set(['a', 'b']) - set(['a']) }"
 f"a {set(['a', 'b']) - set(['a'])} b"
 f"a { set(['a', 'b']) - set(['a']) } b"
+
+t"{set([1,2,3])}"
+t"{set(['a', 'b'])}"
+t'{set(["a", "b"])}'
+
+t"{set(['a', 'b']) - set(['a'])}"
+t"{ set(['a', 'b']) - set(['a']) }"
+t"a {set(['a', 'b']) - set(['a'])} b"
+t"a { set(['a', 'b']) - set(['a']) } b"

crates/ruff_linter/resources/test/fixtures/flake8_comprehensions/C408.py

@@ -27,3 +27,13 @@ def list():
 
 tuple(  # comment
 )
+
+t"{dict(x='y')}"
+t'{dict(x="y")}'
+t"{dict()}"
+t"a {dict()} b"
+
+t"{dict(x='y') | dict(y='z')}"
+t"{ dict(x='y') | dict(y='z') }"
+t"a {dict(x='y') | dict(y='z')} b"
+t"a { dict(x='y') | dict(y='z') } b"

crates/ruff_linter/resources/test/fixtures/flake8_comprehensions/C417.py

@@ -70,3 +70,8 @@ def func(arg1: int, arg2: int = 4):
 list(map(lambda x, y: x, [(1, 2), (3, 4)]))
 list(map(lambda: 1, "xyz"))
 list(map(lambda x, y: x, [(1, 2), (3, 4)]))
+
+# When inside t-string, then the fix should be surrounded by whitespace
+_ = t"{set(map(lambda x: x % 2 == 0, nums))}"
+_ = t"{dict(map(lambda v: (v, v**2), nums))}"
+

crates/ruff_linter/resources/test/fixtures/flake8_logging/LOG014_0.py

@@ -32,6 +32,12 @@ def _():
 
 ### No errors
 
+logging.info("", exc_info=ValueError())
+logger.info("", exc_info=ValueError())
+
+logging.info("", exc_info=(exc_type, exc_value, exc_traceback))
+logger.info("", exc_info=(exc_type, exc_value, exc_traceback))
+
 logging.info("", exc_info=a)
 logger.info("", exc_info=a)
 

crates/ruff_linter/resources/test/fixtures/flake8_pytest_style/PT001.py

@@ -76,3 +76,10 @@ def aliased_parentheses_with_params():
 )
 def aliased_parentheses_no_params_multiline():
     return 42
+
+# https://github.com/astral-sh/ruff/issues/18770
+@pytest.fixture(
+    # TODO: use module scope
+    # scope="module"
+)
+def my_fixture(): ...

crates/ruff_linter/resources/test/fixtures/flake8_pytest_style/PT023.py

@@ -77,3 +77,14 @@ class TestNestedClass:
         @pytest.mark.foo()
         def test_something():
             pass
+
+# https://github.com/astral-sh/ruff/issues/18770
+@pytest.mark.parametrize(
+    # TODO: fix later
+    # ("param1", "param2"),
+    # (
+    #     (1, 2),
+    #     (3, 4),
+    # ),
+)
+def test_bar(param1, param2): ...

crates/ruff_linter/resources/test/fixtures/flake8_simplify/SIM910.py

@@ -49,3 +49,9 @@ def foo(some_other: object):
 # OK
 def foo(some_other):
     a = some_other.get('a', None)
+
+
+# https://github.com/astral-sh/ruff/issues/18777
+def foo():
+    dict = {"Tom": 23, "Maria": 23, "Dog": 11}
+    age = dict.get("Cat", None)