Skip to content

Commit 2a425e4

Browse files
authored
[UP008]: use super(), not __super__ in error messages (#18743)
When I try to grep CPython with `__super__` I get 0 results: ``` (.venv) ~/Desktop/cpython main ✔ » ag __super__ . ``` That's how we can understand that the naming is not the best.
1 parent cb512ba commit 2a425e4

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

crates/ruff_linter/src/rules/pyupgrade/rules/super_call_with_parameters.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ impl AlwaysFixableViolation for SuperCallWithParameters {
5858
}
5959

6060
fn fix_title(&self) -> String {
61-
"Remove `__super__` parameters".to_string()
61+
"Remove `super()` parameters".to_string()
6262
}
6363
}
6464

crates/ruff_linter/src/rules/pyupgrade/snapshots/ruff_linter__rules__pyupgrade__tests__UP008.py.snap

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ UP008.py:17:23: UP008 [*] Use `super()` instead of `super(__class__, self)`
99
18 | super(Child, self).method # wrong
1010
19 | super(
1111
|
12-
= help: Remove `__super__` parameters
12+
= help: Remove `super()` parameters
1313

1414
Unsafe fix
1515
14 14 | Parent.super(1, 2) # ok
@@ -30,7 +30,7 @@ UP008.py:18:14: UP008 [*] Use `super()` instead of `super(__class__, self)`
3030
19 | super(
3131
20 | Child,
3232
|
33-
= help: Remove `__super__` parameters
33+
= help: Remove `super()` parameters
3434

3535
Unsafe fix
3636
15 15 |
@@ -53,7 +53,7 @@ UP008.py:19:14: UP008 [*] Use `super()` instead of `super(__class__, self)`
5353
22 | | ).method() # wrong
5454
| |_________^ UP008
5555
|
56-
= help: Remove `__super__` parameters
56+
= help: Remove `super()` parameters
5757

5858
Unsafe fix
5959
16 16 | def wrong(self):
@@ -76,7 +76,7 @@ UP008.py:36:14: UP008 [*] Use `super()` instead of `super(__class__, self)`
7676
| ^^^^^^^^^^^^^^^ UP008
7777
37 | super().f()
7878
|
79-
= help: Remove `__super__` parameters
79+
= help: Remove `super()` parameters
8080

8181
Unsafe fix
8282
33 33 |
@@ -95,7 +95,7 @@ UP008.py:50:18: UP008 [*] Use `super()` instead of `super(__class__, self)`
9595
| ^^^^^^^^^^^^^^^ UP008
9696
51 | super().f()
9797
|
98-
= help: Remove `__super__` parameters
98+
= help: Remove `super()` parameters
9999

100100
Unsafe fix
101101
47 47 | super(MyClass, self).f() # CANNOT use super()
@@ -115,7 +115,7 @@ UP008.py:74:14: UP008 [*] Use `super()` instead of `super(__class__, self)`
115115
| ^^^^^^^^^^^^^^^^^ UP008
116116
75 | super().f() # OK
117117
|
118-
= help: Remove `__super__` parameters
118+
= help: Remove `super()` parameters
119119

120120
Unsafe fix
121121
71 71 | @dataclass
@@ -134,7 +134,7 @@ UP008.py:92:14: UP008 [*] Use `super()` instead of `super(__class__, self)`
134134
92 | super(__class__, self).foo()
135135
| ^^^^^^^^^^^^^^^^^ UP008
136136
|
137-
= help: Remove `__super__` parameters
137+
= help: Remove `super()` parameters
138138

139139
Unsafe fix
140140
89 89 |
@@ -153,7 +153,7 @@ UP008.py:107:23: UP008 [*] Use `super()` instead of `super(__class__, self)`
153153
107 | builtins.super(C, self)
154154
| ^^^^^^^^^ UP008
155155
|
156-
= help: Remove `__super__` parameters
156+
= help: Remove `super()` parameters
157157

158158
Unsafe fix
159159
104 104 |

0 commit comments

Comments
 (0)