Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show syntax error notification on manual invocation #12176

Open
dhruvmanila opened this issue Jul 4, 2024 · 0 comments
Open

Show syntax error notification on manual invocation #12176

dhruvmanila opened this issue Jul 4, 2024 · 0 comments
Labels
server Related to the LSP server

Comments

@dhruvmanila
Copy link
Member

To quote Micha:

Let's say you have a very long document and the syntax error is outside the visible area. It might now be unclear to users why the manually triggered action does nothing.

RustRover does show an error when running rustfmt failed because of a syntax error and I find this useful information.

I also think this is a useful indicator but might be difficult to achieve for a language server. This can be achieved at least for code actions using the CodeActionTriggerKind but for other requests like formatting and workspace command it's difficult without having full control over both the client and the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Related to the LSP server
Projects
None yet
Development

No branches or pull requests

1 participant