[Infinite loop] I002 and UP035

[dscorbett]

Summary

Ruff fails to converge when missing-required-import (I002) and deprecated-import (UP035) are selected and a deprecated import is required.

$ echo 1 | ruff --isolated check - --select I002,UP035 --config 'lint.isort.required-imports=["from collections import Sequence"]' --fix

error: Failed to converge after 100 iterations.

This indicates a bug in Ruff. If you could open an issue at:

    https://github.com/astral-sh/ruff/issues/new?title=%5BInfinite%20loop%5D

...quoting the contents of `-`, the rule codes I002, along with the `pyproject.toml` settings and executed command, we'd be very appreciative!

from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
from collections.abc import Sequence
1
-:1:1: I002 Missing required import: `from collections import Sequence`
Found 101 errors (100 fixed, 1 remaining).
[*] 1 fixable with the `--fix` option.

Version

ruff 0.11.0 (2cd25ef 2025-03-14)

[ntBre]

I haven't looked closely enough to know if this is a good approach, but the fix could possibly be similar to the changes in #15480.

[dylwil3]

I think in this particular case another option could be to just not offer the fix for UP035 here, or even maybe ignore the rule altogether for required imports.

[AlexWaygood]

or even maybe ignore the rule altogether for required imports.

this makes sense to me. If we do this, we could even say in the docs for UP035 that one way of configuring the rule (excluding certain deprecated-import upgrades) is to specify the lint.isort.required-imports setting.