Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autofix for missing whitespace rules in E pycodestyle (preview) #8121

Closed
7 tasks done
Skylion007 opened this issue Oct 22, 2023 · 2 comments
Closed
7 tasks done

Autofix for missing whitespace rules in E pycodestyle (preview) #8121

Skylion007 opened this issue Oct 22, 2023 · 2 comments
Labels
fixes Related to suggested fixes for violations good first issue Good for newcomers

Comments

@Skylion007
Copy link
Contributor

Skylion007 commented Oct 22, 2023 •
edited by charliermarsh
Loading

  • E225
  • E226
  • E227
  • E228
  • E231
  • E252
  • E275

All these rules are very similar, already implemented, and have a trivial autofix that should be added. It would also be a good first issue since the autofix is an easy one to write. @charliermarsh you may want to add a good-first-issue label.
@Skylion007 Skylion007 changed the title Add autofix for missing whitespace rules in E prefix (preview) Autofix for missing whitespace rules in E prefix (preview) Oct 22, 2023
@Skylion007 Skylion007 changed the title Autofix for missing whitespace rules in E prefix (preview) Autofix for missing whitespace rules in E pycodestyle (preview) Oct 22, 2023
@dhruvmanila dhruvmanila added the fixes Related to suggested fixes for violations label Oct 23, 2023
@charliermarsh charliermarsh added the good first issue Good for newcomers label Oct 23, 2023
This was referenced Oct 23, 2023
Merged
Merged
@reswqa
Copy link
Contributor

reswqa commented Oct 23, 2023

Thanks, I'd like to take this to better understand ruff code base.

This was referenced Oct 23, 2023
Merged
Merged
@charliermarsh
Copy link
Member

Thanks @reswqa! Great work!

charliermarsh pushed a commit that referenced this issue Oct 23, 2023
@reswqa
add auto-fix for E275 (#8133)
8338143 
## Summary

First time contribute to `ruff`, so If there are low-level errors,
please forgive me. 🙇

Introduce auto fix for `E275`, this partially address #8121.

## Test Plan

Already coverd.
charliermarsh pushed a commit that referenced this issue Oct 23, 2023
@reswqa
add auto-fix for E252 (#8142)
5a95b25 
## Summary

Introduce auto fix for `E252`. This partially address #8121.

## Test Plan

Already covered.
charliermarsh pushed a commit that referenced this issue Oct 23, 2023
@reswqa
add auto-fix for E225,226,227,228 (#8136)
7100e12 
## Summary

Introduce auto fix for `E225`,`E226`,`E227`,`E228`. This partially
address #8121.

## Test Plan

Already covered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@charliermarsh @Skylion007 @reswqa @dhruvmanila