Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't read source files in formatter when there is a cache hit #8132

Closed
konstin opened this issue Oct 23, 2023 · 0 comments · Fixed by #8134
Closed

Don't read source files in formatter when there is a cache hit #8132

konstin opened this issue Oct 23, 2023 · 0 comments · Fixed by #8134
Labels
formatter Related to the formatter

Comments

@konstin
Copy link
Member

konstin commented Oct 23, 2023

Currently, we always read source files in formatter even when we hit the cache. With a hacky change, not reading source files is 10% faster with a hot cache. The task is to refactor the formatter result types so that we don't read the source files if we hit the cache and don't need them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants