Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type annotation parsing API to return Parsed #11739

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update type annotation parsing API to return Parsed #11739

merged 1 commit into from
Jun 5, 2024

Conversation

dhruvmanila
Copy link
Member

Summary

This PR updates the return type of parse_type_annotation from Expr to Parsed<ModExpression>. This is to allow accessing the tokens for the parsed sub-expression in the follow-up PR.

Test Plan

cargo insta test

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Jun 4, 2024
@dhruvmanila dhruvmanila requested a review from MichaReiser as a code owner June 4, 2024 16:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@dhruvmanila dhruvmanila merged commit eed6d78 into main Jun 5, 2024
19 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/type-annotation-parsed branch June 5, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvmanila @MichaReiser