Skip to content

Conversation

@kaxil
Copy link
Contributor

@kaxil kaxil commented Mar 11, 2025

Similar to #16014. PR on Airflow side: apache/airflow#47639

Summary

Similar to #16014. PR on Airflow side: apache/airflow#47639

Test Plan

a test fixture has been updated

cc @Lee-W @dhruvmanila

@github-actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+153 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

apache/airflow (+153 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ airflow/example_dags/example_asset_with_watchers.py:45:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ airflow/example_dags/example_bash_decorator.py:112:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ airflow/example_dags/example_bash_decorator.py:113:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ airflow/example_dags/example_complex.py:160:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ airflow/example_dags/example_complex.py:190:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ airflow/example_dags/example_complex.py:214:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ airflow/example_dags/example_short_circuit_decorator.py:42:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ airflow/example_dags/example_short_circuit_decorator.py:43:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ airflow/example_dags/example_short_circuit_decorator.py:57:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ airflow/example_dags/example_short_circuit_operator.py:51:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ airflow/example_dags/example_short_circuit_operator.py:52:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ airflow/example_dags/example_short_circuit_operator.py:66:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ dev/perf/dags/elastic_dag.py:194:26: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ performance/src/performance_dags/performance_dag/performance_dag.py:259:26: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_appflow.py:101:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_appflow_run.py:181:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_athena.py:158:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_azure_blob_to_s3.py:64:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_batch.py:257:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_bedrock.py:112:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_bedrock.py:113:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_bedrock.py:145:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_bedrock.py:146:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_bedrock.py:207:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_bedrock_retrieve_and_generate.py:110:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_bedrock_retrieve_and_generate.py:111:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_bedrock_retrieve_and_generate.py:566:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_cloudformation.py:100:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_comprehend.py:117:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_comprehend.py:73:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_comprehend_document_classifier.py:108:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_comprehend_document_classifier.py:197:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_datasync.py:216:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_dms.py:407:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_dms_serverless.py:344:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_dynamodb.py:108:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_dynamodb_to_s3.py:160:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_dynamodb_to_s3.py:161:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_dynamodb_to_s3.py:241:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_ec2.py:186:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_ecs.py:198:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_ecs_fargate.py:145:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_eks_templated.py:134:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_eks_with_fargate_in_one_step.py:130:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_eks_with_fargate_profile.py:160:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_eks_with_nodegroup_in_one_step.py:142:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_eks_with_nodegroups.py:181:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_emr.py:206:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_emr_eks.py:299:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
+ providers/amazon/tests/system/amazon/aws/example_emr_notebook_execution.py:101:5: AIR302 `airflow.models.baseoperator.chain` is removed in Airflow 3.0
... 103 additional changes omitted for project

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
AIR302 153 153 0 0 0

Copy link
Contributor

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MichaReiser MichaReiser requested a review from dhruvmanila March 13, 2025 11:49
@dhruvmanila dhruvmanila added rule Implementing or modifying a lint rule preview Related to preview mode features labels Mar 18, 2025
@dhruvmanila dhruvmanila changed the title [airflow] Add chain, chain_linear and cross_downstream for AIR302 [airflow] Add chain, chain_linear and cross_downstream for AIR302 Mar 18, 2025
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@dhruvmanila dhruvmanila merged commit b7d232c into astral-sh:main Mar 18, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Related to preview mode features rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants