Skip to content

Conversation

@MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Mar 14, 2025

Summary

Follow-up release for Ruff v0.10 that now includes the following two changes that we intended to ship but slipped:

Test plan

I verified that the binary built on this branch respects the requires-python setting (logs, left: v0.10, right: v0.11)

@MichaReiser MichaReiser added the release Related to the release process label Mar 14, 2025
CHANGELOG.md Outdated

## 0.11.0

This is largely a follow-up release to Ruff 0.10.0 because we accidentally didn't include the new `requires-python` inference changes. Ruff 0.11.0 now includes this change as well as the stabilization of `PGH004`'s preview behavior
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestions for how we could phrase this instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

This is a follow-up to release 0.10.0. Because of a mistake in the release process, the requires-python inference changes were not included in that release. Ruff 0.11.0 now includes this change as well as the stabilization of the preview behavior for PGH004.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Copy link
Collaborator

@dylwil3 dylwil3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Possible re-wording suggestion and a question on whether we should further edit the 0.10 changelog.

CHANGELOG.md Outdated

> Note: Because of a mistake in the release process, the `requires-python` inference changes are not included in this release and instead shipped as part of 0.11.0.
In previous versions of Ruff, you could specify your Python version with:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete the rest of the section and end the note above by saying "The description of this change can be found in the changelog entry for 0.11.0" or something along those lines?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, especially since they're so close together. We could even strikethrough the headline? That might be going too far, though.

Comment on lines 32 to 33
> Note: Because of a mistake in the release process, the `requires-python` inference changes are not included in this release and instead shipped as part of 0.11.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we could use a NOTE1 here if we want:

Note

Because of a mistake in the release process, the requires-python inference changes are not included in this release and instead shipped as part of 0.11.0.

I'm not sure if that will render everywhere this file is displayed, though, maybe only on GitHub.

Footnotes

  1. https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts

CHANGELOG.md Outdated

> Note: Because of a mistake in the release process, the `requires-python` inference changes are not included in this release and instead shipped as part of 0.11.0.
In previous versions of Ruff, you could specify your Python version with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, especially since they're so close together. We could even strikethrough the headline? That might be going too far, though.

@MichaReiser MichaReiser merged commit 2cd25ef into main Mar 14, 2025
39 checks passed
@MichaReiser MichaReiser deleted the micha/ruff-0.11 branch March 14, 2025 12:57
dcreager added a commit that referenced this pull request Mar 14, 2025
* main:
  [red-knot] Use `try_call_dunder` for augmented assignment (#16717)
  [red-knot] Document current state of attribute assignment diagnostics (#16746)
  [red-knot] Case sensitive module resolver (#16521)
  [red-knot] Very minor simplification of the render tests (#16759)
  [syntax-errors] Unparenthesized assignment expressions in sets and indexes (#16404)
  ruff_db: add a new diagnostic renderer
  ruff_db: add `context` configuration
  red_knot: plumb through `DiagnosticFormat` to the CLI
  ruff_db: add concise diagnostic mode
  [syntax-errors] Star annotations before Python 3.11 (#16545)
  [syntax-errors] Star expression in index before Python 3.11 (#16544)
  Ruff 0.11.0 (#16723)
  [red-knot] Preliminary tests for typing.Final (#15917)
  [red-knot] fix: improve type inference for binary ops on tuples (#16725)
  [red-knot] Assignments to attributes (#16705)
  [`pygrep-hooks`]: Detect file-level suppressions comments without rul… (#16720)
  Fallback to requires-python in certain cases when target-version is not found (#16721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Related to the release process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants