[red-knot] Silence unresolved-attribute in unreachable code
#17305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Member
|
The new error in text_encoding = (
io.text_encoding # type: ignore[unused-ignore, attr-defined]
if sys.version_info > (3, 10)
else _text_encoding
) |
sharkdp
force-pushed
the
david/unreachable-attribute-expressions
branch
3 times, most recently
from
05454c1 to
1a76d8e
Compare
sharkdp
changed the title
unresolved-attribute diagnostics in unreachable code
sharkdp
changed the title
unresolved-attribute diagnostics in unreachable codeunresolved-attribute in unreachable code
sharkdp
force-pushed
the
david/unreachable-attribute-expressions
branch
from
1a76d8e to
2b51fed
Compare
sharkdp
force-pushed
the
david/unreachable-attribute-expressions
branch
from
2b51fed to
d1a5619
Compare
Contributor
Author
@MichaReiser Is this something specific to this PR, or just a general thought? Anything that should be done about it? |
Contributor
Author
|
I manually checked that nothing changed in pybind11, so I'm ignoring the spurious cycle-panic-diff there. |
Member
I'll create a separate issue for it |
dcreager
added a commit
that referenced
this pull request
Apr 10, 2025
* main: (30 commits) [red-knot] Silence `unresolved-import` in unreachable code (#17336) red_knot_python_semantic: move TODO comment red_knot_python_semantic: rename `lint()` and `report()` ruff_db: use `Annotation::get_message` in more places red_knot_python_semantic: tweak docs on building reporter builders red_knot_python_semantic: remove the "old" secondary message type red_knot_python_semantic: replace one use of "old" secondary diagnostic messages red_knot_python_semantic: update revealed type snapshots ruff_db: tweak how the revealed type diagnostic is rendered red_knot: add explicit test for concise `reveal_type` diagnostic red_knot_python_semantic: remove `InferContext::report_diagnostic` red_knot_python_semantic: add "reporter" API Bump 0.11.5 (#17337) [red-knot] Silence `unresolved-attribute` in unreachable code (#17305) Revert "[red-knot] Type narrowing for assertions (#17149)" (#17335) [red-knot] Type narrowing for assertions (#17149) [red-knot] avoid unnecessary evaluation of visibility constraint on definitely-unbound symbol (#17326) update cargo-dist (#17325) [red-knot] Fix double hovers/inlays in playground (#17334) [red-knot] Track reachability of scopes (#17332) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Basically just repeat the same thing that we did for
unresolved-reference, but now for attribute expressions.We now also handle the case where the unresolved attribute (or the unresolved reference) diagnostic originates from a stringified type annotation.
And I made the evaluation of reachability constraints lazy (will only be evaluated right before we are about to emit a diagnostic).
Test Plan
New Markdown tests for stringified annotations.