Skip to content

[refurb] Add fix safety section (FURB129) #17498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[refurb] Add fix safety section (FURB129) #17498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88bfffc
add fix safety section to docs
Kalmaegi Apr 20, 2025
eec65a2
adjust doc
Kalmaegi Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/ruff_linter/src/rules/refurb/rules/readlines_in_for.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ use crate::checkers::ast::Checker;
/// ...
/// ```
///
/// ## Fix safety
///
/// This fix is marked as unsafe if the file is iterated multiple times,
/// replacing `readlines()` with direct iteration may consume the file
/// contents in earlier iterations, resulting in empty results for
/// subsequent iterations.
///
/// ## References
/// - [Python documentation: `io.IOBase.readlines`](https://docs.python.org/3/library/io.html#io.IOBase.readlines)
#[derive(ViolationMetadata)]
Expand Down
Loading