Skip to content

Conversation

@sharkdp
Copy link
Contributor

@sharkdp sharkdp commented May 1, 2025

Summary

closes #17122

Test Plan

  • New hover tests
  • Opened the playground locally and saw that new hover-types are shown as expected.

@sharkdp sharkdp added the ty Multi-file analysis & type inference label May 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2025

mypy_primer results

No ecosystem changes detected ✅

@sharkdp sharkdp force-pushed the david/hover-type-for-assignments branch 2 times, most recently from 22d4562 to ca9c247 Compare May 1, 2025 09:48
@sharkdp sharkdp marked this pull request as ready for review May 1, 2025 09:55
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sharkdp sharkdp force-pushed the david/hover-type-for-assignments branch from ca9c247 to 8a18046 Compare May 1, 2025 17:59
@sharkdp sharkdp merged commit e515899 into main May 1, 2025
35 checks passed
@sharkdp sharkdp deleted the david/hover-type-for-assignments branch May 1, 2025 18:33
dcreager added a commit that referenced this pull request May 2, 2025
* main:
  [red-knot] Refactor: no mutability in call APIs (#17788)
  [red-knot] Fix panic for `tuple[x[y]]` string annotation (#17787)
  [red-knot] Implicit instance attributes in generic methods (#17769)
  doc: Add link to `check-typed-exception` from `S110` and `S112` (#17786)
  Fix module name in ASYNC110, 115, and 116 fixes (#17774)
  [red-knot] More informative hover-types for assignments (#17762)
  [syntax-errors] Use consistent message for bad starred expression usage. (#17772)
  red_knot_server: add auto-completion MVP
  Allow passing a virtual environment to `ruff analyze graph` (#17743)
  Bump 0.11.8 (#17766)
  [`flake8-use-pathlib`] Fix `PTH104`false positive when `rename` is passed a file descriptor (#17712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[red-knot] Store the value type for name expressions in store context.

4 participants